[Barry]

That definitely sounds like it could be useful here – thanks for sharing, Derek 🙂

[Barry]

Glad the fix worked and I’ll certainly share that idea with the team for further discussion.

Thanks again and if anything else crops up please do feel free to create a new topic 🙂

[Barry]

Ah yes, some of the code in those custom functions was a slightly mixed up. Here’s a freshened up version:

https://gist.github.com/anonymous/d30e20ecd9e17f61843d

I hope that helps! I do want to note though that, generally speaking, custom dev tasks like this are something you need to drive forward – and maintain – under your own steam.

I didn’t want to leave you high and dry here since see you’ve been persevering with this for a while and through a number of support exchanges – however as a rule of thumb the code we offer up here in the forums should be regarded as a starting point that you can take and tweak by yourself.

In any case, I do hope that gets you closer 🙂

[Barry]

Thanks for sharing!

Edit: that gist embed is vicious on the eyes, and it doesn’t collapse, is there a way to make a gist embed look a little nicer?

Some of our theme’s formatting rules are ‘leaking’ into the embedded gists – the zebra striping effect in particular is a little strong – and I believe we have a plan to address that, albeit it’s a fairly low priority.

However, we will address it (and making them collapsible isn’t a bad idea at all – I’ll be sure to log that) 🙂

[Barry]

I’m not sure why you’re experiencing that – did you update both functions and can you share your current code for this modification?

(A Gist or Pastebin URL is best – thanks!)

[Barry]

Hi Karly,

So you’ve got two functions in your snippet – comm_default_end_time() and comm_default_end_time() – and right now they run every time the Community Events editor form is displayed.

In this case, we really only need them to run the first time the editor displays: if the form has already been submitted, you don’t need or want to interfere with those time selectors.

To that end, try adding the following piece of code at the top of each function:

// Don't interfere if the form has been submitted
if ( ! empty( $_POST ) ) {
	return $output;
}

For example, the start of your comm_default_start_time() function should look something like this:

function comm_default_start_time( $output, $event_id ) {
	// Don't interfere if the form has been submitted
	if ( ! empty( $_POST ) ) {
		return $output;
	}

	if ( ! $event_id ) {
	/* ... rest of the function  ... */ 

Hopefully that fixes things for you 🙂

[Barry]

Hi @simpleconnections – a Gist URL is a great way to share code. Just pop the URL on a line of its own in your reply and the code will be embedded here in the forums (or you could of course provide the URL to other similar services likes Pastebin, though we don’t support automatic embedding for those).

[Barry]

Hi Douglas,

On looking at your system information and thinking through the nature of the error, I wonder if resolving this might be as simple as visiting the Events → Import → Import Settings tab and hitting the save button (you need not change anything).

Could you give that a go and then try manually importing an event one more time? If you still hit the same problem, can I ask you to again share a copy of your system information? Specifically, I’d be interested to know what the value of imported_post_status is at that point (which is contained in the sys info).

Thanks!

[Barry]

Thanks Konrad 🙂

[Barry]

Great!

[Barry]

We’ll definitely do our best to update the thread when we’ve got something to report re the fix 🙂 (failing that, our blog and our changelogs will also reflect the change).

Is there a way to add a class for expired dates so we can hide them with CSS?

Well, you could just not output them at all. Above:

$dates[ tribe_get_start_date( $possible_id, false, 'U' ) ] = tribe_get_start_date( $possible_id );

You could add:

if ( tribe_get_start_date( $possible_id, false, 'U' )  < date_i18n( 'U' ) )
    continue;

[Barry]

If you’ve checked the notify me of follow-ups by email box then yep, you should get an alert each time we update this topic (and if you haven’t, feel free to reply again and do so then) 🙂

In terms of timelines I’m afraid I can’t offer any guarantees there – we’re literally discussing this right now and so don’t have a firm idea just yet. What I can say is it is very unlikely to be the very next release – since that is in code freeze (we’re in the final stages of preparation before release).

We do hope to follow up shortly after that with a further maintenance release and if we can roll this in there we’ll do so, but again that isn’t a certainty. Perhaps in the interim – though I appreciate it isn’t ideal – you could create events without exclusions, then manually remove the ones you don’t want by trashing them via the main events admin list?

[Barry]

Hi @inhouse,

Unfortunately, it may be this is a bug in Events Calendar PRO after all.

Your recurrence rules should indeed result in three events (one on the 18th and two on the 20th) because of your exclusion rule for the 19th … however, it seems that isn’t actually being respected.

I misinterpreted your previous post to suggest the extra dates were somehow only creeping in via the snippet – but on trying to replicate the problem with the very same rules, it seems to me that it is nothing to do with the snippet as such (which is simply picking up on the events that have been generated). Rather the problem is that the exclusion rule is being ignored and those events on the 19th are still being created.

We have had a few problems with custom exclusions and many of those issues will be ironed out in our next few releases – but I’ll be sure to check that this is amongst them (and we’ll update this topic as soon as a fix for this is released).

Thanks again for your patience.

[Barry]

Hi @inhouse,

I don’t think this is a bug in The Events Calendar/Events Calendar PRO as such, it’s just that the snippet I provided was a fairly simple one that doesn’t cater to more complicated use cases.

As highlighted earlier in the exchange, the amount of support we can provide for custom dev tasks like this one is rather limited — so, in general, please see snippets like these as a starting point for you to build on and polish rather than a complete and finished solution 🙂

At any rate, here’s a revised and updated version of the snippet:

https://gist.github.com/barryhughes/cfe57641000da38ca249

I hope that helps!

[Barry]

Awesome 🙂

[Author]

Posts