Forum Replies Created
-
AuthorPosts
-
twkmedia
ParticipantHi Patrica,
Thanks for your reply. We did suspect it being a caching issue, but we actually don’t use any caching plugins on the website. Could it be something else?
Thanks
twkmedia
ParticipantHi Hunter,
We’ve managed to fix this ourselves but only by hacking the core plugin. First we found a safe way to add the timezone to the feed using filters:
add_filter( ‘tribe_ical_properties’, __NAMESPACE__ . ‘\\add_ical_timezone’ );
function add_ical_timezone( $content ) {
$content .= “X-WR-TIMEZONE:Europe/London\r\n”;
$content .= “TZID:Europe/London\r\n”;
return $content;
}And this works slightly. It bumps the time so that it is only one hour out!
Then we edited a core file () and changed this function:
private static function wp_strtotime( $string ) {
// If there’s a timezone specified, we shouldn’t convert it
try {
$test_date = new DateTime( $string );
if ( ‘UTC’ != $test_date->getTimezone()->getName() ) {
return strtotime( $string );
}
} catch ( Exception $e ) {
return strtotime( $string );
}
$tz = get_option( ‘timezone_string’ );
if ( ! empty( $tz ) ) {
$date = date_create( $string, new DateTimeZone( $tz ) );
if ( ! $date ) {
return strtotime( $string );
}
$date->setTimezone( new DateTimeZone( ‘UTC’ ) );
return $date->format( ‘U’ );
} else {
$offset = (float) get_option( ‘gmt_offset’ );
$seconds = intval( $offset * HOUR_IN_SECONDS );
$timestamp = strtotime( $string ) – $seconds;
return $timestamp;
}
}So that it no longer adjusts the time for timezone, and just returns the time in it’s original format.
From what we can tell $test_date->getTimezone()->getName() is returning UTC when it shouldn’t be.
On the basis that if we update the plugin this fixed will be lost, I wonder why we pay for the Events Calendar PRO?
Thanks
Ben
twkmedia
ParticipantHi Hunter,
Surely this kind of issue isn’t going to be a conflict with another plugin or anything like that? A conflict might break something but it wouldn’t just throw all the calendar events in the ical feed out by a couple of hours?!
Thanks
Ben
twkmedia
ParticipantHi Hunter,
These are the steps we are following when we find this issue: http://hamptonprep.org.uk/whats-on/calendar-subscribe/
Specifically the first set of APPLE ICAL INSTRUCTIONS.
Thanks
Ben
twkmedia
ParticipantThis reply is private.
twkmedia
ParticipantHi George,
Thanks for clarifying. Let’s hope that solves our problem. Could you let me know when this update is available?
We’ll give the cut-off time a try and see if that helps.
All the best.
Pete
twkmedia
ParticipantHi George,
Thanks for the update. So, will you next maintenance release fix the problem we have, or just do something that could fix it?
Thanks
twkmedia
ParticipantHi George,
Thanks for the update. Please let me know if there’s anything else you need from me.
Thanks
twkmedia
ParticipantHi George,
Could you please let me know how you’re getting on with fixing this bug?
Thank you.
twkmedia
ParticipantHi George,
Another update. We’ve compared the actual ics file between new (v 4.1.0.1) and old (v 3.0.4) versions, and the end date in the new version is definitely wrong.
Looking specifically at “IGCSE English Speaking + Listening Exams”, the correct date is from 12/04 to 14/04.
It’s correctly displayed with the old version but it ends one day earlier with new version.
Old version: start: 20160412 – end: 20160415
New version: start: 20160412 – end: 20160414It’s a bit confusing as it looks like the event needs to end one day later than expected
to be correct in the calendar.See https://cloudup.com/cT–FBP6iYE
Any progress from your side?!
Thanks
twkmedia
ParticipantHi George,
We’ve updated the DEV site to use the latest version of The Events Calendar (v 4.1.0.1) but the problem still remains.
See https://cloudup.com/cBV3GvP0u0P – the event starting on 2/29 and ending on 3/11. But in the calendar/feed the event ends on 3/10 – https://cloudup.com/cGPcsasV_wB – one day early.
Clearly the latest version also has this bug.
Thanks
twkmedia
ParticipantHi George,
Thanks for taking a look.
Sure, we’ll update to the latest version and see if that resolves. I’ll let you know. Yes, we used the outdated version of the plugin because that was the last time it worked correctly! I’ll let you know when the dev site is updated too.
Below is the LIVE site system info (please note we’ve not updated it to latest version yet at time of sending):
URL
INSTALL KEYS
events-calendar-pro = 4f7c3fee187998bbfcfe9279d8977e4ce35348af
WORDPRESS VERSION
4.4.2
PHP VERSIONThanks
5.3.29
PLUGINS
Redirector version 3.0.1 by Ralf Hortt
Regenerate Thumbnails version 2.2.6 by Alex Mills (Viper007Bond)(http://www.viper007bond.com/)
TubePress version 3.1.8 by TubePress LLC(http://tubepress.com)
WordPress Importer version 0.6.1 by wordpressdotorg(http://wordpress.org/)
Yoast SEO version 3.1 by Team Yoast(https://yoast.com/)
NETWORK PLUGINS
Advanced Custom Fields: Repeater Field version 1.1.1 by Elliot Condon(http://www.elliotcondon.com/)
Admin Menu Tree Page View version 2.6.9 by Pär Thernström(http://eskapism.se/)
Advanced Custom Fields version 4.4.5 by Elliot Condon(http://www.elliotcondon.com/)
The Events Calendar PRO version 4.0.5 by Modern Tribe, Inc.(http://m.tri.be/20)
EWWW Image Optimizer version 2.5.9 by Shane Bishop(https://ewww.io/)
Gravity Forms version 1.9.16.8 by rocketgenius(http://www.rocketgenius.com)
MCE Table Buttons version 3.2 by Jake Goldman, 10up, Oomph(http://10up.com)
TablePress version 1.7 by Tobias Bäthge(https://tobias.baethge.com/)
The Events Calendar version 4.0.5 by Modern Tribe, Inc.(http://m.tri.be/1x)
WordPress Database Backup version 2.3.0 by Austin Matzko(http://austinmatzko.com/)
WPide version 2.4.0 by Simon @ WPsites(http://www.wpsites.co.uk)
MU PLUGINS
–
THEME
Senior Boys – St James School
MULTISITE
1
SETTINGS
tribeEventsTemplate = calendar.php
tribeEventsBeforeHTML =
tribeEventsAfterHTML =
previous_ecp_versions = Array
(
[0] => 0
[1] => 2.0.11
[2] => 3.0.2
[3] => 4.0.5
)
latest_ecp_version = 4.0.6
welcome_notice = 1
displayedPressTrendsDialogue = 1
donate-link =
viewOption = month
eventsSlug = calendar
singleEventSlug = calendar
postsPerPage = 10
showComments =
multiDayCutoff = 12:00
embedGoogleMaps = 1
embedGoogleMapsHeight = 350
embedGoogleMapsWidth = 100%
embedGoogleMapsZoom = 10
sendPressTrendsData =
debugEvents =
recurring_events_are_hidden = exposed
disable_metabox_custom_fields = show
stylesheetOption = tribe
tribeEnableViews = Array
(
[0] => upcoming
[1] => month
[2] => week
[3] => day
)
tribeDisableTribeBar =
hideLocationSearch = 1
monthEventAmount = 7
liveFiltersUpdate = 1
hideSubsequentRecurrencesDefault =
userToggleSubsequentRecurrences =
showEventsInMainLoop =
defaultCurrencySymbol = $
geoloc_default_geofence = 25
geoloc_default_unit = miles
schema-version = 4.0.6
earliest_date = 2013-07-05 00:00:00
latest_date = 2017-07-05 23:59:59
pro-schema-version = 4.0.5
pue_install_key_events_calendar_pro = 4f7c3fee187998bbfcfe9279d8977e4ce35348af
WORDPRESS TIMEZONE
Europe/London
SERVER TIMEZONE
UTC
COMMON LIBRARY DIR
/home/stjamesschoolsco/public_html/wp-content/plugins/the-events-calendar/common/src/Tribe
COMMON LIBRARY VERSION
4.0.5twkmedia
ParticipantHi George,
It strikes me as VERY unlikely that another plugin would have affected the Events Calendar iCAL feed don’t you? I don’t think you need Outlook to see the issue – you can see the problem in the data in the feed i.e. that the end times are not correct.
Would be really grateful if someone could look at the difference between the iCAL feed in the new versions of the plugin, and version 3.0.4 which we know had a feed that worked exactly as it should.
Thanks
Ben
twkmedia
ParticipantHi George,
This lays out all the issues pretty clearly: https://docs.google.com/document/d/1YJlJ5KJD-uNbIrv3HAHWkyLxbIrB4OdQZq25vZRzHQI/edit?usp=sharing
All the best,
Ben
twkmedia
ParticipantHi George,
No, its the same unfortunately. We’ve done a 301 redirect, /ical-tribeevents.ics is old URL from an old version of the plugin but client asked if it was possible to keep /ical-tribeevents.ics as feed because it stopped working for users that have susbcribed to /ical-tribeevents.ics.
So we’ve done a 301 but /ical-tribeevents.ics and /?ical are exactly the same.
I have a word doc that clearly sets out the issues. How can I send this to you?
All the best,
Ben
-
AuthorPosts
