Forum Replies Created
-
AuthorPosts
-
MartyParticipant
This reply is private.
MartyParticipantFor sure! Here’s an example, as plugin:
MartyParticipantOkay, sorted it. The solution was as simple as clearing the permalink on that post, and letting it automatically fill back in.
(I have theories about the chain of events that led to the error… but they’re not interesting enough to post here.)
Thanks for your assistance on this.
MartyParticipantThe early access to release candidates doesn’t have much utility, honestly. It’s going to take time to negotiate budget for testing, then schedule development work, then do the testing, then make any necessary changes. It doesn’t matter to me if the code is “release candidate” or the actual release– the work it creates on my end is the same.
What I’m trying to communicate is that by breaking backwards compatibility, or even just introducing the potential to break compatibility, Tribe is putting devs like me in a tough spot. If I’ve done my customizations according to the suggested approach and am using methods documented in the API, I should be able to hit “update” without worry.
MartyParticipantThis reply is private.
MartyParticipantGordon, you’re not alone. I’ve been asking for this for years, too. I’m “halfempty” on Twitter, if you’d like to discuss.
MartyParticipantClosing
MartyParticipantHi there. I’m working around this function and won’t be using it. So I’m marking this thread as closed, though as far as I know the bug persists. Thanks for your help.
MartyParticipantHi. Looks like we’re very close. One thing, though. This line:
`$link = get_term_link( tribe_meta_event_category_name(), ‘tribe_events_cat’ );’
get_term_link() wants either an object, ID or slug, but
tribe_meta_event_category_name() returns the category name.What will give us the ID or slug? Thanks!
MartyParticipantYes, my question is about API functions only. Please note that this thread is a follow-up to a previous thread:
https://theeventscalendar.com/support/forums/topic/problem-with-tribe_get_past_link/
And what I’m saying is that I wasn’t getting the proper result from the code from that previous thread. So could you please double-check that solution (which might be the patch slated for the next release?) and confirm it’s returning the correct result for you?
Thanks!
MartyParticipantClose, but not quite. It needs to have the current category slug in there, as applicable.
MartyParticipanttribe_get_listview_link() returns:
/events/category/mycategory/list/
In order to construct the URLs, it looks like the bast I need is:
/events/category/mycategory/
Is there a method that will output that?
MartyParticipantIt’s not the links I’m asking about. I’m asking about the output of tribe_get_past_link(). It’s var_dump’d at the top and results in:
http://test.martyspellerberg.com/events/category/mycategory/list?tribe_event_display=past/
As you can see, that link returns “Upcoming Events.” The proper link to past events appears to be:
http://test.martyspellerberg.com/events/category/mycategory/?tribe_event_display=past
MartyParticipantHere’s my test site. It’s a child theme of 2015 containing a copy of the /views/ material, modified to include var_dumps:
http://test.martyspellerberg.com/events/category/mycategory/list/
Permalinks are set to /%postname%/
Thanks!
MartyParticipantGeorge et al,
No, I’m sorry, that’s not working. What I’m getting, using it on Category list views, is simply a link to the page I’m already on.
Big picture, it looks like when the URL scheme was changed from “/past/” to “?tribe_event_display=past” (not sure if that was 3.8 or 3.9), a bunch of functions were not properly updated, including tribe_get_past_link(), tribe_get_upcoming_link(), tribe_get_listview_link() and potentially others that I haven’t tested.
If that’s the case, may I request that they be all be fixed and fully tested for 4.0? That way instead of doing all this back and forth now, I can go back to my client and say, “Hey, listen, 3.9 is no good. We need to hold out ’till 4.0, then update.” ‘Cause all this back and forth is way past what we budgeted for what was meant to be a routine plugin update.
Please let me know if that’s a viable way forward. Thanks!
-
AuthorPosts