[Tom Stone]

Haha, yes “yikes” indeed! 😀
I get your point – as far as bugs go, this is quite benign.
Still… if a value is entered at one place, and the formatting is set in one place, it seems odd that other versions will appear on the same page.

I tried the two code snippets, each on their own, and then together. No luck!

As seen in the screen capture, the formatting is the same on two places and different on the third.

In Swedish currency, we have always a space between the value and the unit. Decimals are optional.
So these are ok:
10 kr and 10,00 kr.
These are not ok:
10kr and 10,00kr.
And whatever format is used, it should be consistent on the page.

[Tom Stone]

I found the errors!

On line 107-118 in the file “tribe-options-general.php” (in The Events Calendar), in the “multiDayCutoff”-array, are the times hardcoded to the AM format.

Also, on line 249 in the file “Updater.php” (in The Events Calendar), is this:

tribe_update_option( ‘multiDayCutoff’, $eod_cutoff->format( ‘h:i’ ) );

Which is using a 12-hour time (h:i) instead of the 24-hour time (H:i).

[Tom Stone]

It seems to be the correct time format everywhere else, except in the section where you set when the end of day should be, for events that runs past midnight. In settings (general):
……/wp-admin/edit.php?page=tribe-common&tab=general&post_type=tribe_events
I’m guessing the format is hardcoded there. It is not an important setting to many people, so I guess it has simply been forgotten.

I’m not at my developer computer at the moment. So the system info have to wait for now. Sorry.

[Tom Stone]

Cool!
I didn’t know that in A() && B(), B() is never tested if A() is false. Nifty! 🙂

[Tom Stone]

I updated to the latest version of the extension, and the fatal error returned.

So I amended line 108 in wp-content/plugins/event-tickets/common/src/Tribe/App_Shop.php again.
This time like this:

'is_installed' => class_exists( 'Tribe__Events__Aggregator' )?Tribe__Events__Aggregator::is_service_active():false,

That is, a ternary operator that first checks if the class exist. If true, it returns the “service active” status. If false, it returns false.

[Tom Stone]

I’m not able to reproduce this on my site. Since this isn’t currently a known issue, please follow these recommended troubleshooting steps for your own site:

It would be nice if my report actually was read before giving the standard form answer.

The reason you are not able to reproduce this on your site is likely because you (1) have the Event Aggregator extension installed, and (2) didn’t disable it before checking if a fatal error happens when it isn’t present.
If you do disable the Events Aggregator extension, I think you’ll be able to reproduce the bug without any effort at all.

As the error report said, Fatal error: Class ‘Tribe__Events__Aggregator’ not found in /customers/1/a/b/uppsalamagicandcomedy.se/httpd.www/wp-content/plugins/event-tickets/common/src/Tribe/App_Shop.php on line 108
Reading line 108 in that file makes it very clear why the bug happens. It is checking if an extension is installed by asking that very extension to return an answer – which it can do only if it is installed. When not installed, it can’t respond to calls, ergo; fatal error.
If
Line 108: ‘is_installed’ => Tribe__Events__Aggregator::is_service_active(),
is changed to
Line 108: ”is_installed’ => class_exists( ‘Tribe__Events__Aggregator’),
the fatal error goes away at once, and the everything works as intended.

[Tom Stone]

Thanks!
Will this be rolled into the main plugin at a future date? A reminder to uninstall this would be useful in that case.
Btw, isn’t it better to import these settings from Woocommerce? Feels a bit odd to do the same settings twice, in two different places, since those settings are imported from Woocommerce elsewhere in your extension.

[Tom Stone]

No need to make a snippet for my sake. Thanks for the offer though. 🙂
However, making sure the docs and the reality is in agreement is a good thing. Saves time! Either mention that the anchor isn’t present in the stand-alone version. Or add it in a future update.

Thanks.

[Tom Stone]

“Regarding the ‘#buy-tickets’ anchor, I’m seeing it on my local test site when I add RSVP and/or WooCommerce tickets to events”

Maybe the ‘#buy-tickets’ anchor on your test site is added by some other Tribe plugin than “Event Tickets Plus”?
At the moment I can’t switch themes – too much functionality is still in functions.php and haven’t been moved to a plugin yet. But my theme is built on the Underscores (_s) theme, so it is unlikely the theme is the problem.

Here’s the URL: http://uppsalamagicandcomedy.se/magikongress/

[Tom Stone]

Seems to be other things missing as well.
At Events -> Settings -> Display, it says “The following three fields accept…” – but there are not three fields, it’s just one field.

[Tom Stone]

“Can you head over to Events -> Settings -> General and change the default currency value ?”

No such setting exist.
The screen capture below show everything that is available at Events -> Settings -> General.

[Tom Stone]

Oh, sorry, I didn’t know there were an online translation hub.
Unfortunately, I don’t have the stamina to do it all over again. If you can’t use the files I’ve posted, someone else have to provide an updated translation.

I used Poedit, and updated the language files from the POT file before I begun, so it should be up to date.

[Author]

Posts