V4 update problems (not bad so far!)

[Mad Dog]

I’ve updated three plugins (TEC, Pro, Community Events) and so far in quick testing only see a couple of problems.

– First, my Photo view goes to a 404 error page. Never did before. It goes to …/category/uncategorized/photo/. I’ve reset Permalinks (which are quite pretty, thank you). What the…..? (Sorry to have piggybacked on another thread about this)

– Second, there’s supposed to be a link on the My Events page to “show old events”. I was in on the suggestion to do this and would hate not to have it. But it’s not showing up. I’ve customized this page a bit so does it have to do with my using an old template page? If so, can I add some new code to it? I hope I don’t have to try to make the same changes to a new template page because, well…my documentation sometimes leaves a lot to be desired.

Could be more, but so far looking good!

RSVP

THANKS

[George]

Hey @Mad dog,

First of all I’m sorry to hear about the Photo View issue – I will investigate this and see if there’s a bug I can recreate here.

—

As for the second issue, my “My Events” page works fine and so I’m wondering if your customizations are at all a factor here. I would recommend first backing up all customizations on your site; then, temporarily remove them and see if anything is improved on your site.

If not, then can you include your “system information” in your reply? Here’s how to do that → https://theeventscalendar.com/knowledgebase/sharing-sys-info/

Cheers,
George

[Mad Dog]

Hi George–

Let me know what you find about the Photo View problem. Since I’m not the only one having this problem hopefully you can recreate it and figure out what’s going on.

As to the second part, which was funny because it was a feature I helped get included….I got it fixed. Yes, there’s a new section of code in event-list.php that handles this. Comparing my file with the new one in Notepad++ found the section right off the bat, I added it, and VOILA! Beautiful!

I did find a code rewrite near the bottom of the new page that’s handling a function differently than it was and wondered if I should copy that over too or just leave well enough alone. This is the new section:

<td>
  <?php echo esc_html( tribe_get_start_date( $post->ID, Tribe__Events__Community__Main::instance()->eventListDateFormat ) ) ?>
 </td>

 <td>
 <?php echo esc_html( tribe_get_end_date( $post->ID, Tribe__Events__Community__Main::instance()->eventListDateFormat ) ) ?>
</td>

What do you think? Copy it or leave things alone?

I guess I should be better about commenting my changes so updates don’t do this, but it’s the cost of customization.

THANKS for the help.

MD

• This reply was modified 10 years, 4 months ago by Mad Dog.

[George]

Hey @Mad Dog,

Thanks for the update here, and yes, you are right about not being the only person with the Photo View issue; there are actually some bugs at play there and we are working on fixes for that. Very sorry for the trouble with that!

In regards to your customizations, I’m glad progress has been made. You asked about the other bit of code there, and to be honest it’s really your call whether to leave it alone or not. The code you pasted shows an event start time, and end time.

• Do you need that functionality where this displays?
• Does everything work fine if you copy this code?

If so, then go ahead and copy the code over! 😀

If you don’t need the functionality, or if you copy it over but then problems arise, then you do not need to copy this over – or can do so later when you have time to carefully implement it without issues.

Customizations are indeed tricky for these sorts of reasons, so ultimately this is your decision and I hope the information I’ve provided here helps – even a little bit.

Best of luck with your customizations!

— George

[Mad Dog]

Keep me posted about the Photo Bug.

There’s already code in the old template that does the same thing. I noticed these lines have been rewritten in the new version and didn’t know if it had anything to do with deprecated functions or more secure code….or is it just another way of doing what’s already there.

Thanks,
MD

[George]

Thanks @Mad Dog,

And to comment further on that code, the code from the new files is indeed more recent, and you will / should copy over this new code at some point.

I would personally recommend it; use as much of the latest code in your own customized version as possible.

Best of luck with your customizations,
George

[Mad Dog]

Thanks. It’s copied with no known ill effects. (:})

[Mad Dog]

Oh crud….the Photos page bug fix didn’t make it into 4.0.1….

[George]

I’m sorry about that @Mad Dog! If you go through all of the steps listed here, does that help at all? → https://theeventscalendar.com/knowledgebase/fixing-http-404-errors/

[Mad Dog]

Tried those right off. This has been replicated and logged as a bug (https://theeventscalendar.com/support/forums/topic/week-and-photo-views-produce-404-page-after-pro-4-0-update/) but probably wasn’t as critical a problem as those that made the first update.

[George]

Thanks for staying on top of this, @Mad Dog, I have indeed looked up the current development ticket and this is under development. I’m sorry that this is the best news for the moment 🙁

Please let me know what you think and if you have further questions for the time being.

Sincerely,
George

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Author]

Posts