Translations issues with Events Community V4.0.5

[Oliver]

Hi Geoff,

unfortunately none of the problems described here have been solved with the new version:

https://theeventscalendar.com/support/forums/topic/issues-with-german-translation-in-events-calendar-4-0/#post-1077099
https://theeventscalendar.com/support/forums/topic/veranstaltung-event-displayed-in-lower-case/#post-1077078

I installed it on three different WordPress installations but I got everywhere the same results.

Here is an example:
a) “submitted” is not translated
b) “Veranstaltung” is still in lower case
https://www.dropbox.com/s/ghkflciwm0famdt/Screenshot%202016-02-17%2023.25.58.png?dl=0

Best regards,
Oliver

[Nico]

Hey Oliver,

Thanks for reaching out on this, and sorry to hear those two bugs are still not fixed in the MR 🙁

Taking a look into the ‘lowercase’ report, I see this was fixed + tested in The Events Calendar Core. Maybe that’s why it’s still an issue in Community Events, I’m not familiarized on what change was made at code level to address this but maybe it has to be ported to other plugins. I’ll ask the dev assigned to that ticket and will let you know.

Regarding the ‘submitted’ translation, I’ve took a look into the code and found that there’s an extra white space in the string in the plugin files, which seems to be removed (maybe automatically) by the translation plugin. So if you take a look at the translation in the plugin file (the-events-calendar-community-events/src/Tribe/Submission_Handler.php:85), you’ll see the following:


$this->add_message( sprintf( __( '%s submitted. ', 'tribe-events-community' ), $events_label_singular ) . $this->community->get_view_edit_links( $this->event_id ) );


To fix this now, please change that line to:


$this->add_message( sprintf( __( '%s submitted.', 'tribe-events-community' ), $events_label_singular ) . ' ' . $this->community->get_view_edit_links( $this->event_id ) );


I’m logging this bug now and hope it makes it to the next maintenance release as the fix is super simple 🙂

I’ll update you on the first one when I hear back from the dev,
Best,
Nico

[Oliver]

Hi Nico,

thanks for the bugfix! That worked like a charm 🙂

I hope the other bugs are fixed in the next release.

Best regards,
Oliver

[Nico]

Thanks for confirming Oliver 🙂

Regarding the capitalization, I could confirm this was only fixed + QA’d in Core, but the fix is likely to work on other plugins. I’ll log this so this is also extended to other plugins. If you see any other place where this is happening (events in lower case), please point them out!

Thanks,
Nico

[Oliver]

Ok, sounds good! I’m looking forward for the next MR!

These are the only places where I found the “veranstaltungen” in lower case currently:
https://www.dropbox.com/s/uafk3ihfn0wh8zj/Screenshot-tp-jazz-1.png?dl=0
https://www.dropbox.com/s/mg93us6l60i20bw/Screenshot%202016-02-22%2019.51.23.png?dl=0

Apart from that I guess that the latest translations I made on The Events Calendar Plugin on https://translate.wordpress.org have not been used in the actual MR:

https://www.dropbox.com/s/h9plmrt84sna7yr/Screenshot%202016-02-22%2019.54.45.png?dl=0
https://www.dropbox.com/s/pfoa6g416xxk5qt/Screenshot%202016-02-22%2019.55.32.png?dl=0

Can you address that they will be included in the next MR?
How is the process for translations? I would expect that on every release they will be included to make sure that everything is up-to-date?!?

Regards,
Oliver

[Nico]

Thanks as usual Oliver 🙂

https://www.dropbox.com/s/mg93us6l60i20bw/Screenshot%202016-02-22%2019.51.23.png?dl=0

^ Can you tell me what this says in English? I’ll specifically add this string to the ticket!

Can you address that they will be included in the next MR?

I’ve logged the issue, not sure if there will be a MR for all plugins, before 4.1 (which is about to be released). I’ve given it a high priority as this a bug in something we ‘incompletely’ fixed. I can understand it’s a pain for you, and of course it requires more time from everyone!

How is the process for translations? I would expect that on every release they will be included to make sure that everything is up-to-date?!?

Latest translations are pulled in before packing the release ZIP files. In fact I can see that string in the translation files. And a deeper look indicates the translation is getting correctly pulled in to the ‘Event’ post type labels (the ‘view_item’ label, use this code in functions to check on this https://goo.gl/FX6vKG), no not sure why WP is not using that label! I’ll double check on that…

Thanks once again for the help on the German side of things,
Best,
Nico

[Oliver]

Hi Nico,

https://www.dropbox.com/s/mg93us6l60i20bw/Screenshot%202016-02-22%2019.51.23.png?dl=0

^ Can you tell me what this says in English? I’ll specifically add this string to the ticket!
This means that the events lies in the past 😉

Thanks for the code, this look like a nice way to find translation issues.
I will have a look at it on the weekend.

Cheers,
Oliver

[Nico]

Hey Oliver,

Thanks for translating that! I’m getting better with my ‘calendar german’ but at pretty slow pace 😛

So, the thing is that event single label string is getting transformed by strtolower before output on the-events-calendar/src/Tribe/Templates/Single_Event.php line 119. I guess this was missed in the previous ticket. Will note it in the bug report so it gets fixed!

Will continue to investigate the ‘View %s’ post type translation glitch, couldn’t find more on it yet…

Thanks,
Nico

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Leah]

Hello,

Thank you for reporting this issue. We weren’t able to get a fix for it into our upcoming release (4.1). However, please know that the problem is still on our radar and is ticketed within our system to be addressed in a future maintenance release. We’ll do our best to keep you posted when we are able to get a solution in place. Thank you for your patience while we improve and expand our plugins.

Best,
Leah

[Geoff]

Hey Oliver,

I’m happy to say that we were able to work this into version 4.1.1 which we shipped last night. Please update to the latest version if you haven’t already and do let us know if you continue to see any issues from there. 🙂

Cheers and thanks for your patience while we worked on this!

Geoff

[Author]

Posts