Forum Replies Created
-
Posts
-
EDIT: The issue also appears a second time in the-events-calendar/src/Tribe/Template/Month.php on line 577
Something like this:
window.foo = 'bar';As opposed to:
window.localStorage.foo = 'bar';And maybe check to see if localStorage is available before deciding whether or not to use it: http://stackoverflow.com/a/16427747
Since you’re asking for other thoughts – I haven’t looked at the code, but I can’t imagine that you’re storing that much. Why not just fall back to memory if local storage isn’t available?
Since this issue extends beyond Filter Bar and into core functionality of The Events Calendar, if there’s any way that I can fix at least some of these cases using an existing filter, that would be very much appreciated.
Can you offer any suggestions? (Otherwise, if there’s nothing you can do, go ahead and close the ticket.)
The best solution for this was provided in this support topic. The Advanced Custom Fields plugin has absolutely everything I want out of custom fields including and especially the ability to apply the fields conditionally based on post type (so they only affect Event posts).
Thanks! Feel free to close this ticket.
Ok, I have posted a feature request: http://tribe.uservoice.com/forums/195723-feature-ideas/suggestions/10376586-add-description-text-for-custom-fields
I will also check out the Advanced Custom Fields plugin – thank you for the suggestion.
Feel free to close the ticket.
Thanks!
Ok, no worries. This is arguably a feature rather than a bug – if a user visits the site and opens the filters, maybe it is useful for the filters to be open when the user visit the site next.
Feel free to close the ticket.
Most of the issue was fixed by fixing the body classes as described here: https://theeventscalendar.com/support/forums/topic/month-view-tooltip-not-working-2/#dl_post-1017636 (the CSS above was no longer necessary)
Only one small quirk remains: When I open the calendar in a new browser tab, regardless of whether Filters Default State is set to opened or closed, the state is the same as was in the previous browser tab
This is not affected by disabling the Month View Cache, which would be my only guess. Any thoughts?
Thanks!
I bet you guys love it when people solve their own problems 🙂
The problem was that the Awake theme uses a custom function ( mysite_body_class() ) for setting body classes instead of the standard body_class(), so any classes added by placing filters on body_class were effectively ignored. The fix was to change the following in header.php:
Before:
// header.php <body class="<?php mysite_body_class(); ?>">After:
// header.php <? ob_start(); mysite_body_class(); $awake_classes = explode( ' ', ob_get_contents() ); ob_end_clean(); ?> <body <?php body_class( $awake_classes ); ?>>Also worth noting that I am experiencing some other JS oddities with this theme that do not produce any errors: https://theeventscalendar.com/support/forums/topic/showcollapse-not-hiding-filters-correctly/
Ah, ok, I didn’t realize Featured Image was a wordpress feature and not an ECP feature. That info is enough to get me started.
Thanks!
The reason I would prefer not to change the “Date without year” setting is because it affects a global value. I wouldn’t know what other templates refer to that value, and in some of those cases, maybe I would want not to show the year. I am effectively abusing that field, because I am putting a year value in the format described as “without year”.
It’s true, I could just change the single event template – I forgot about that :-/
I ended up changing the format, because I think it is likely that I want to show the year in all cases that the short format is used. However, it would be helpful to have a list of all templates that use the short form (i.e. without year if event is in current year). Can you provide such a list so I can spot-check them?
Thank you!
I was able to trace it down to a conflict with the Awake 3.2 theme we are using. For the sake of anybody else reading this, the offending call trace follows:
views/default-template.phpwas invokingget_header();which was callingheader.phpof the theme. At the bottom of header.php is a call tomysite_before_page_content();Then, in framework.php, there are several calls toadd_actionthat add various hooks to the mysite_before_page_content function. One of those hooks ismysite_query_postswhich preloads posts to be used in a sidebar, etc.I’m not sure exactly what the conflict is with that function, but my guess is that its use of
global $wp_queryconflicts with that same variable that is used in the nav of Events Calendar. The solution then was to avoid calling that function by putting the following line inviews/default-template.phpbefore the call to get_header():remove_action( 'mysite_before_page_content', 'mysite_query_posts' );
