Home › Forums › Ticket Products › Community Tickets › Community Events/Tickets Styles
- This topic has 6 replies, 4 voices, and was last updated 9 years, 4 months ago by
Chris.
-
AuthorPosts
-
November 24, 2016 at 5:10 am #1196966
Chris
ParticipantI’m sure you’re aware of this:
styles like : .eventForm h4 are always going to collide and should be .tribe_community_events .eventForm {} or if used across plugins should be .tribe .eventForm h4 {}
One of the offenders right here:
should be ‘tribe-events-form’ or something with ‘tribe’ prefix, and then bubble… #sigh #lazy
<div class=”tribe-events-community-details eventForm bubble” id=”event_custom”>
one line below:
id ‘event-meta’… how about ‘tribe-event-meta’
<table id=”event-meta” class=”tribe-community-event-info”>
Now I’m going to have to write a script to rename everything so I can upgrade to dot releases…. #sigh
At least (i hope) this will be the last of my issues… will post my versions when I’m done for reference… #aka will have to be done over night tonight #sigh
November 24, 2016 at 4:48 pm #1197195Nico
MemberHey Chris,
Thanks so much for reaching out to us on this! Let me say I don’t quite get your point here.
styles like : .eventForm h4 are always going to collide and should be .tribe_community_events .eventForm {} or if used across plugins should be .tribe .eventForm h4 {}
You mean eventForm is a pretty generic class and can conflict with other plugins / theme stylesheet? Are you suggesting we should add more ‘tribe-‘ prefix to our elements?
Now I’m going to have to write a script to rename everything so I can upgrade to dot releases…. #sigh
Sorry about this 🙁 Again, I don’t think I get what changed. Did you upgrade the plugins recently and the class names were different?
Please let me know about it,
Best,
NicoNovember 25, 2016 at 9:34 am #1197502Chris
Participantit’s too easy for other classes to be ‘eventForm’ and override key layout items, also for javascript to manipulate that.
I guess you’ve got to realise that most theme makers grab a wordpress framework (in my case the themer used Redux) which carelessly (and I’ve reported it to them also) uses generic classes also, and to add to that uses a minifier that reduces script variables to a,b,c… in the global scope #OMG.
At least you guys had the brains to use scoped javascript (even after minification)… #thanks so you’re most of the way there…
It would also be great if you limited the scope of your plugins also (aka to slugs that are /event + /shop and grab the others from shop config) so that it helps our site run faster outside the event pages… which would help to reduce some of the bazillion style and javascript files on every request (that most aren’t needed sadly).
also would love to see the /community slug be optionally removed from community events, and just use /events as they are just another author really (or contributor)… Already added that to the UV page.
November 25, 2016 at 2:57 pm #1197632Nico
MemberThanks for clarifying Chris!
I already have a reminder to talk about this with one of the front-end devs in our team next week.
I’ll give you a heads-up when I hear back from her,
Have a great weekend,
NicoNovember 29, 2016 at 3:35 pm #1199436Nico
MemberHey Chris,
I just chatted with one of our devs and she told me that some changes and improvements are coming to the CSS of Community Events in next feature release (release schedule). They are aware there’s room for improvement, but there’s also the need to maintain certain backwards compatibility. Hopefully the improvements will come soon to other products like Event Tickets.
Please let me know if there’s anything else I can help you with,
Best,
NicoDecember 21, 2016 at 8:35 am #1208916Support Droid
KeymasterHey there! This thread has been pretty quiet for the last three weeks, so we’re going to go ahead and close it to avoid confusion with other topics. If you’re still looking for help with this, please do open a new thread, reference this one and we’d be more than happy to continue the conversation over there.
Thanks so much!
The Events Calendar Support Team -
AuthorPosts
- The topic ‘Community Events/Tickets Styles’ is closed to new replies.
