Forum Replies Created
-
AuthorPosts
-
January 12, 2018 at 4:01 pm in reply to: Recurring events w/ a lot of exclusions breaks event #1425309
jon
ParticipantI tried uploading the patch file here but it wouldn’t let me, I’ve hosted it on dropbox: https://www.dropbox.com/s/s75cecxnz8ktmg6/__fix_select2_dom_processing_issues_with_recurring_event_exclusions.patch?dl=0 this is based on Events Calendar Pro Version 4.4.20.1 and edited events-recurrence.js. I’ll also summarize my changes below in case that helps. Basically this removes the select2 initialization on page load, and moves it into only initializing the select2 when the fields are revealed to the dom. This happens either when you change the recurrence type (month, year, etc) or when you view the details of an existing one by clicking view details. Using my patch with only 17 exclusions my backend page dom loads in 5.6 seconds (this is a pretty resource intensive site on its own). Without my patch it takes 31.21 seconds to load.
— REMOVE Lines 128 – 130 —
my.init_dropdowns = function() {
$( ‘.recurrence-row .tribe-dropdown’ ).tribe_dropdowns();
};— Add under my.event.recurrence_type_changed = function() { —
$rule.find(‘.tribe-dropdown’).tribe_dropdowns();— Add under my.toggle_rule = function( $rule, state ) { [under each $rule.addClass(‘tribe-open’) lines] —
$rule.find(‘.tribe-dropdown’).tribe_dropdowns();p.s. this could be optimized further as it looks like the select2 is used on a lot of elements that really don’t need it. Most of the select boxes only have 1-3 options, so the select2 is basically useless and only serves to suck up dom bandwidth. I would suggest using it only on elements that truly need it like the month tag picker element. Decisions like that would need to come from your dev team however, so my patch only includes the basics necessary to speed it up.
January 11, 2018 at 3:29 pm in reply to: Recurring events w/ a lot of exclusions breaks event #1424201jon
ParticipantThanks Victor. Is there any ideas from the dev team on what might be causing the load issues? If I solve the problem myself, can I submit a patch to you somehow for inclusion? Or is it a closed development process where you don’t accept fixes?
jon
ParticipantThanks Courtney. Is there any way to have data from events calendar automatically post to the relevant fields in the all in one plugin?
jon
ParticipantThanks for your quick response Courtney. Are you based in the DC area? We’d be happy to offer you a complementary tour if you’re in the area. 🙂
The site has actually been posting site maps to google via Yoast for several months, and Google is refreshing indexes of the site around once a week.
Is it possible there is some kind of error in our theme or something? And would you mind sending the names of other Events Calendar based sites showing up in rich snippets so I can do additional troubleshooting?
Thanks!
-
AuthorPosts
