Forum Replies Created
-
AuthorPosts
-
August 25, 2018 at 1:47 am in reply to: Filter Bar "View As" toggle getting a display: none applied incorrectly #1605671RyanParticipant
Thanks for the info. Using an !important override did fix the issue. This behavior must have changed in a recent Event Calender release, which is a tad annoying considering that I’m using the Skeleton style setting which is supposed to avoid behavior conflicts like this. My code had been working for the previous 4+ years without issue. Still, good to have an viable workaround so thank you for that.
RyanParticipantHi Cliff, any update on when this will be fixed? Thanks!
RyanParticipantHi Cliff, thanks for confirming the issue. Looking forward to the fix when it’s available.
RyanParticipantHi Cliff,
I had some time to dig into this further and found a few interesting things.
If I switch the Events Settings > Default Stylesheet to either Full Styles or Tribe Styles, the 3-column layout works fine. This is why it works on your demo site. However the Skeleton style option has issues.
- One issue with TEC’s Skeleton stylesheet is that you don’t provide a width for .tribe-events-photo-grid-sizer in your Skeleton stylesheet. I tried adding that to my custom stylesheet and it didn’t solve the issue, but I’m sure this is part of the solution because Isotope requires setting the grid-sizer to a value in order to layout the rest of the grid properly.
- Secondly, I think something is not firing correctly with your custom Isotope JS implementation. One of the core issues is that your JS is not properly overriding the opacity: 0 that gets applied by your stylesheet to the #tribe-events-photo-events element. If you flip this CSS value on my prod site, you’ll see that the content indeed then appears (although it’s not laying out properly in 3-columns still). I picked through your tribe-events-photo-view.js and the logic in function tribe_setup_isotope looked a bit suspect, although the issue may be elsewhere. The bottomline is that the JS isn’t properly setting the needed CSS values on Isotope load.
FYI, I tested turning off all my custom CSS that applies to the Photo view. This had no effect on the issue. I don’t believe there is any conflict occurring with my custom code. Also, because flipping to the Full Styles or Tribe Styles “fixes” the issue, I don’t believe there is any conflict occurring with other plugins. I believe the issue lies in how TEC is handling Skeleton styles with the Isotope v3 upgrade.
Hope that helps, look forward to your thoughts.
-
AuthorPosts