Home › Forums › Calendar Products › Events Calendar PRO › Take 3: Removing Scripts/Styles on pages they shouldn't be loading
- This topic has 9 replies, 4 voices, and was last updated 9 years, 9 months ago by
Allen Presher.
-
AuthorPosts
-
July 11, 2016 at 10:59 am #1138236
Allen Presher
ParticipantUpdate 4.2.2 does not fix the loading of assets we noted.
As an aside it’s difficult to discuss bugs when threads are closed and comments are deleted. Both the e-mail we received and previous thread say to contact you guys if there’s still an issue, but we do not see any way to do so other than to open a third thread on the same problem.
July 11, 2016 at 11:15 am #1138251George
ParticipantHey @Stratejusinc,
I’m sorry to hear that issues are persisting.
You never responded to our replies in that other thread, so for starters:
1. Did the code fix I wrote for you in that other thread help at all?
2. Can you post your site’s complete System Information to this thread so that I can investigate your site’s makeup at this time? If we find different things on different pages, then I can compare my site’s makeup to yours and use that information to try and recreate your issues.
3. Can you specify which exact scripts and stylesheets load where they’re not supposed to, now that you’ve updated to 4.2.2?
Our support forums are indeed the best avenue for discussing issues with our plugins, so thank you for opening a new thread. And to be clear, we do not close threads ourselves most of the time, unless an issue is resolved. We have a bot that auto-closes threads if there is no activity from the customer after more than 2 weeks, like in that other thread. This helps keep forum content fresh and up-to-date, and helps ensure that people aren’t digging up old threads about old versions of the plugins and reporting issues with more recent versions of the plugins in those old threads—which can make it much harder to provide support to multiple folks at a time, for example.
Thank you for opening a new thread here. I apologize for the inconvenience, and for the fact that the recent update didn’t hit the bullseye on the specific scripts you are mentioning. Please let me know about each of the three things I listed above, and I will see what’s going on here and help us truly resolve this problem.
Sincerely,
GeorgeJuly 11, 2016 at 11:26 am #1138260Allen Presher
ParticipantWe did respond that the code did not work (that was one of the posts deleted), and we did post the exact assets in our original post in the previous thread (which has not yet been deleted).
As for complete system information one of our sites is listed below (client name/url redacted), however this issue is present on every site we have the Events Calendar installed (6-10 currently), and those sites all differ somewhat substantially, and are spread across a few significantly different servers.
HOME URL http://redacted.com SITE URL http://redacted.com INSTALL KEYS events-calendar-pro = df89f7e358d9b61ceebe1bf67df399c974e70bdc WORDPRESS VERSION 4.5.3 PHP VERSION 7.0.8 PLUGINS Gravity Forms version 2.0.2 by rocketgenius(http://www.rocketgenius.com) Admin Menu Editor Pro version 2.3.1 by Janis Elsts(http://w-shadow.com/) Advanced Custom Fields PRO version 5.3.9.1 by Elliot Condon(http://www.elliotcondon.com/) The Events Calendar PRO version 4.2.2 by Modern Tribe, Inc.(http://m.tri.be/20) Gravity Forms Constant Contact Add-On version 2.2.2 by Katz Web Services, Inc.(http://www.katzwebservices.com) Gravity Forms User Registration Add-On version 3.3 by rocketgenius(http://www.rocketgenius.com) InfiniteWP - Client version 1.6.0 by Revmakx(http://www.revmakx.com) Regenerate Thumbnails version 2.2.6 by Alex Mills (Viper007Bond)(http://www.viper007bond.com/) The Events Calendar version 4.2.2 by Modern Tribe, Inc.(http://m.tri.be/1x) TinyMCE Advanced version 4.3.10.1 by Andrew Ozz(http://www.laptoptips.ca/) WP Media folder version 3.7.0 by Joomunited(http://www.joomunited.com) Nested Pages version 1.5.4 by Kyle Phillips(https://github.com/kylephillips) WP Rocket version 2.8.8 by WP Rocket(http://www.wp-rocket.me) WordPress Toolbar Editor version 1.2 by Janis Elsts(http://w-shadow.com/) NETWORK PLUGINS - MU PLUGINS - THEME Stratejus Theme MULTISITE - SETTINGS tribeEnableViews = Array ( [0] => list [1] => month ) schema-version = 4.2.2 recurring_events_are_hidden = exposed previous_ecp_versions = Array ( [0] => 0 [1] => 3.12.6 [2] => 4.0 [3] => 4.0.1 [4] => 4.0.2 [5] => 4.0.3 [6] => 4.0.4 [7] => 4.0.5 [8] => 4.0.6 [9] => 4.0.7 [10] => 4.1 [11] => 4.1.0.1 [12] => 4.1.1 [13] => 4.1.1.1 [14] => 4.1.2 [15] => 4.1.3 [16] => 4.1.4 [17] => 4.2 [18] => 4.2.1 [19] => 4.2.1.1 ) latest_ecp_version = 4.2.2 last-update-message = 4.2.1.1 disable_metabox_custom_fields = hide pro-schema-version = 4.2.2 donate-link = postsPerPage = 10 liveFiltersUpdate = 1 hideSubsequentRecurrencesDefault = userToggleSubsequentRecurrences = recurrenceMaxMonthsBefore = 24 recurrenceMaxMonthsAfter = 24 showComments = showEventsInMainLoop = multiDayCutoff = 00:00 defaultCurrencySymbol = $ reverseCurrencyPosition = embedGoogleMaps = 1 geoloc_default_geofence = 25 geoloc_default_unit = miles embedGoogleMapsZoom = 10 debugEvents = tribe_events_timezone_mode = event tribe_events_timezones_show_zone = eventsSlug = calendar singleEventSlug = event stylesheetOption = tribe tribeEventsTemplate = viewOption = month tribeDisableTribeBar = hideLocationSearch = 1 hideRelatedEvents = week_view_hide_weekends = monthEventAmount = 3 enable_month_view_cache = dateWithYearFormat = F j, Y dateWithoutYearFormat = F j monthAndYearFormat = F Y weekDayFormat = D jS dateTimeSeparator = @ timeRangeSeparator = - datepickerFormat = 0 tribeEventsBeforeHTML = tribeEventsAfterHTML = earliest_date = 2015-07-04 00:00:00 latest_date = 2016-11-18 16:30:00 pue_install_key_events_calendar_pro = df89################################0bdc earliest_date_markers = Array ( [0] => 1957 ) latest_date_markers = Array ( [0] => 1471 ) WORDPRESS TIMEZONE - SERVER TIMEZONE UTC COMMON LIBRARY DIR /home/clients/public_html/redacted/wp-content/plugins/the-events-calendar/common/src/Tribe COMMON LIBRARYJuly 11, 2016 at 2:03 pm #1138376George
ParticipantThank you for this information.
First, you mention that some of your older replies were deleted from the forums—I just wanted to make it clear that we do not delete customer replies from the forums unless the customer explicitly requests it (because of the post having sensitive information or something).
So, if those replies were truly posted and then are gone now, I’m really sorry for the inconvenience of that, and can’t think of a reason why that happened other than some weird technical fluke. Sorry about this!
Back to your actual issues:
Can you provide a list of the stylesheets and scripts that are showing up where they don’t belong? Is it just the scripts and styles of the “This week” widget, for example?
Thank you,
GeorgeJuly 11, 2016 at 2:08 pm #1138381Allen Presher
ParticipantThe assets referred to do appear to all be related the “This week Widget”:
<link rel='stylesheet' id='widget-this-week-pro-style-css' href='http://site.com/wp-content/plugins/theeventscalendar.compu_request_pluginevents-calendar-proversion4.1pu_get_download1pue_active_version4.0-h3e2e3/src/resources/css/widget-this-week-full.css' type='text/css' media='all' /> <link rel='styleshee t' id='tribe_events-widget-this-week-pro-style-css' href='http://site.com/wp-content/plugins/theeventscalendar.compu_request_pluginevents-calendar-proversion4.1pu_get_download1pue_active_version4.0-h3e2e3/src/resources/css/widget-this-week-theme.min.css' type='text/css' media='all' /> <script type='text/javascript'> /* <![CDATA[ */ var tribe_this_week = {"ajaxurl":"http:\/\/site.com\/wp-admin\/admin-ajax.php"}; /* ]]> */ </script> <script type='text/javascript' src='http://site.com/wp-content/plugins/theeventscalendar.compu_request_pluginevents-calendar-proversion4.1pu_get_download1pue_active_version4.0-h3e2e3/src/resources/js/widget-this-week.min.js'></script>I’m glad to hear it is not The Events Calendar policy to delete customer posts. Please let us know if there’s anything else we can provide in troubleshooting this issue.
July 13, 2016 at 5:20 pm #1139433George
ParticipantHey @Stratejusinc,
I am sorry for the delayed response here! I had an unexpected and urgent outage, and was not able to work yesterday. My apologies for the delay in responding here.
In regards to your claims here, I am sorry to say that after a look on my local testing site, I could not find these stylesheets and scripts in all web pages, but DID find them loaded on some pages where they were not needed.
So I have confirmed your claim. We did a pass for this release to try and limit the scope of pages on which specific scripts and stylesheets load–I am sorry to admit that I don’t have a complete explanation as to why or how we missed the “This Week Widget” scripts again, but I will make a new bug report ticket specifically for these stylesheets and scripts.
I will also post a temporary fix here if I am able to put one together myself or with the help of one of our developers.
Thank you for your patience with this issue. Please let me know if there is anything else I can try to help with in the meantime while I create a bug ticket and bring this to the attention of our development team.
Sincerely,
GeorgeJuly 14, 2016 at 7:21 am #1139652Allen Presher
ParticipantThanks, George. We are most concerned about the load time of the homepage (front_page.php), a fix that targeted it first would be the of greatest importance to us and likely to most users’ sites. Part of what makes this a particularly impactful bug isn’t just the assets being loaded by the Events Calendar which are quite small (although the extra HTTP requests are not so good), but it’s actually that the one script requires jQuery and so it takes our jQuery enqueued to the footer and moves it to the header. In other words we end up w/ 90kb of blocking JavaScript that prevents the page from being rendered before we even get to these extra assets that also block the rendering pipeline.
Thank you again for any fix you can provide, this has been an issue of great concern for a number of our clients and has prevented us from rolling the Events Calendar out to any of our in development sites.
July 14, 2016 at 9:37 am #1139778George
ParticipantHey @stratejusinc,
Thanks for your follow-up here. I totally understand the importance of this bug and am wondering about possible fixes, as the dequeue_script calls I shared before did not work on your site. It’s a bit tricky but we are still working on this; stay tuned!
Thank you for your patience,
GeorgeAugust 5, 2016 at 9:35 am #1148228Support Droid
KeymasterThis topic has not been active for quite some time and will now be closed.
If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help. -
AuthorPosts
- The topic ‘Take 3: Removing Scripts/Styles on pages they shouldn't be loading’ is closed to new replies.
