Recurring pages not recognized as calendar pages – not fixed

[Sean]

Just updated to 4.0.7 and found that this issue persists for the Avada theme (it was supposedly fixed in 4.0.6; don’t know if it was fixed in that version, as we updated from 4.0.5).

[Geoff B.]

Good evening yet again Karly,

I want to thank you once again for being so diligent on reporting everything.
In an ideal world, although we enjoy your feedback, this would happen less often as I’m pretty sure you have tons of other wonderful things to do.

I do not Avada available, but I will have to take your word for it and report it to Dev.
Out of curiosity (and to be able to provide better support) are all your threads about a single client or different ones ?

The reason I am asking is because of the lack of system information (as discussed previously) in the current thread.

Could you also confirm if the patch you previously came up with on January 6th still fixes the issue on 4.07 ?

Best regards,

Geoff B.

[Sean]

This reply is private.

[Sean]

Perhaps if the class of the “all” pages was changed, we can apply different values to achieve a workaround? Not sure what the new values should be?

[Geoff B.]

Good afternoon Karly,

Thank you for the system information and for answering my question.

I am looking at the staging page and it does look like the sidebar is displayed properly.

Could it be that you found a workaround with the latest version of our plugins ?

Please let me know if you have a chance.

Have a great day!

Geoff B.

[Sean]

Hi Geoff,

Sorry, no workaround. I am actively doing some work on my staging site, so I no longer have the latest versions of the calendar plugins on staging.

If you know if the conditionals that apply for the “all” pages were changed in the latest version, please let me know what the new ones are, as that should provide a workaround.

These were the original conditionals, which no longer work on the latest version:

if ( tribe_is_recurring_event() && ! is_singular( ‘tribe_events’ ) ) {
    $sidebars = array(
        'global'    => '1',
        'sidebar_1' => Avada()->settings->get( 'ec_sidebar' ),
        'sidebar_2' => Avada()->settings->get( 'ec_sidebar_2' ),
        'position'  => Avada()->settings->get( 'ec_sidebar_pos' ),
    );
}

[Sean]

Geoff, can you please remove the link to my site in your above post ASAP? That is my staging server and I do not want it publicly available.

• This reply was modified 10 years, 1 month ago by Sean.

[Geoff B.]

Hey Karly,

Apologies for this. I have removed the link and will make sure all staging info is kept private in the future.

On another note, I am following up to see if there were any changes to the conditionals being used.

I will get back to you with my findings ASAP.

Have a great day!

Geoff B.

[Geoff B.]

Good afternoon Karly,

After consulting with our Dev staff, the suggestion is to replace your conditional with tribe_is_showing_all()

Could you give this a shot and tell me how it goes ?

Best regards,

Geoff B.

[Sean]

Hi Geoff,

I tried replacing

if ( tribe_is_recurring_event() && ! is_singular( ‘tribe_events’ ) )

with

if ( tribe_is_showing_all() )

but that unfortunately had no effect. Any others that I should try?

Best regards,
Karly

[Geoff B.]

Good afternoon Karly,

Hmmm, that is odd indeed. I’m surprised it did not work since the advice came from one of our top Dev people.

In fact, you can see this very conditional in action at /events-calendar-pro/src/Tribe/Main.php

Would you mind sharing the code for the whole function (in a private reply) so that I can troubleshoot ?

The code should start with public function or function .

Have a great day!

Geoff B.

[Sean]

This reply is private.

[Geoff B.]

Good evening Karly,

Thank you for sharing the complete code.

I will ask for a quick Dev glance at it to be 100% sure. But it looks like it might be a matter of where syntax in the code.

Thank you for sticking with me through this.

Best regards,

Geoff B.

[Geoff B.]

Hello Karly,

As promised I ran it by Dev. For the most part, the code is good.

But, there seems to be a missing closing bracket for the last conditional
if ( tribe_is_showing_all() )

other words, the end of the code should look like
if ( tribe_is_showing_all() ) {
$sidebars = array(
'global' => '1',
'sidebar_1' => Avada()->settings->get( 'ec_sidebar' ),
'sidebar_2' => Avada()->settings->get( 'ec_sidebar_2' ),
'position' => Avada()->settings->get( 'ec_sidebar_pos' ),
);
}
}

Let me know if that helps.

Have a great day!

Geoff B.

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Author]

Posts