Mini Calendar: Slightly buggy markup for wrapper div and table

[inproma]

Hello, dear Tribe people!

The Mini Calendar’s widget content gets wrapped in another <div class=”tribe-mini-calendar-wrapper”>. When switching months, the Ajax call is serving the new content wrapped in yet another <div class=”tribe-mini-calendar-wrapper”> and injects it into the already present one. So you end up with lots of nested <div class=”tribe-mini-calendar-wrapper”>.

What I did in mini-calendar-widget.php to prevent that from happening is this:

<?php $_is_xhr = array_key_exists('action', $_REQUEST) && $_REQUEST['action'] == 'tribe-mini-cal' ?>
<?php if (!$_is_xhr): ?>
<div class="tribe-mini-calendar-wrapper">
<?php endif ?>

(Of course for the closing tag as well.) Not sure if this is the way to go but it definitely helped.
Another issue is that you’re using two <thead> for the calendar table. This is invalid markup and actually causes problems when trying to style this (at least in Chrome).

jQuery, for example, uses a regular <div> to markup the month-switching part.

And you really, really should fix the form for starting a new discussion. My current input for getting this post right looks like this: http://cl.ly/SWi4

Which is quite a mess.

[Barry]

Hi inproma,

We are indeed aware of the first issue (with the ajax responses for the calendar widget) – it’s logged in our issue tracker and should be resolved in an upcoming maintenance build.

Regarding your second point, we’re aware HTML entities are required in order to insert certain characters etc. We hope to make some improvements but for the time being we’d recommend simply dropping in a link to Pastebin, Gist or a similar service for any code you need to share.

Thanks!

[Leah]

Hi there,

I just wanted to pop in here with a quick update. Although we were not able to get a fix for this into our imminent 3.3 release, it is still on the radar for inclusion in a future build. Thanks for your patience!

~Leah

[Leah]

Hi there,

I’m happy to report that we have fixed this in our upcoming version 3.4. Keep an eye on your Plugins page for an update message! Thanks for your patience while we worked on this.

Best,
Leah

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Author]

Posts