Javascript Error in The Events Calendar Pro 3.8.1

Home Forums Calendar Products Events Calendar PRO Javascript Error in The Events Calendar Pro 3.8.1

Viewing 12 posts - 1 through 12 (of 12 total)
  • Author
    Posts
  • #936835
    rdall
    Participant

    There’s a JavaScript error in Events Calendar Pro 3.8.1 when used together with The Events Calendar 3.9.

    > ReferenceError: debug is not defined
    > events-calendar-pro/resources/tribe-events-pro.min.js?ver=3.8.1 (line 12)

    In The Events Calendar, there’s a comment that debug function is stripped from the minified scripts:
    https://plugins.trac.wordpress.org/browser/the-events-calendar/tags/3.8.1/resources/tribe-events.js#L34

    In 3.8, it’s still there (despite the comment):
    https://plugins.trac.wordpress.org/browser/the-events-calendar/tags/3.8.1/resources/tribe-events.min.js#L2

    In 3.9, it’s not:
    https://plugins.trac.wordpress.org/browser/the-events-calendar/tags/3.9/resources/tribe-events.min.js#L1

    However, Events Calendar Pro uses it, so it produces an error when the function is unavailable.

    #936836
    rdall
    Participant

    This reply is private.

    #936850
    Brian
    Keymaster

    Hi,

    Thanks for bringing this up and sorry for the issues you are having, but glad you found a solution.

    The Events Calendar is only compatible with similar version numbers so 3.9 should be used with 3.9 for all the add ons (or 3.9.1)

    If for whatever reason you are unable to upgrade one of the plugins it is best to not upgrade any and keep them at the same version number.

    Although different versions may work together there might be issues such as the conflict you are running into and we do not have a way to fix those beside having you upgrade to the latest version.

    Here is our write up on Version Compatibility for your information:

    https://theeventscalendar.com/knowledgebase/version-compatibility/

    Let me know if you have any follow up questions.

    Thanks

    #936880
    rdall
    Participant

    So what your saying is we should always been updating them together. I believe and though it was understood that and that is what we were doing but when we did that we found the JS Problem.

    We have a staging server which we have updated everything to the lastest version where I removed our filter. And the error still occurs.

    #936884
    rdall
    Participant

    This reply is private.

    #936908
    Brian
    Keymaster

    Ok so I checked out the staging site and it is running Pro 3.8.1 and the Events Calendar 3.9.1 according to the readme.txt in both plugin directories.

    On my site I downgrade Pro to 3.8.1 and I get the debug error in the console right away.

    I then upgraded back to 3.9.1 and the error is gone.

    So it appears to be caused with 3.8.1 Pro running with 3.9.1 the Event Calendar.

    If you get the error after verifying you are running 3.9.1 for both plugins let us know so we can solve it.

    Thanks

    #936922
    rdall
    Participant

    So why isn’t the Pro Version telling our site of the update to the pro plugin?

    The main site has no knowledge of a 3.9.1 Version even available. When I manually downloaded it from The Events Calendar and then uploaded it via ftp to the staging server it does work.

    #937608
    Brian
    Keymaster

    Not sure, I looked at your account and did not see a license connected to a site. Without a current license added to the site you will not get an update notification. If it is under another account please let me know and I can see if there is a connection issue.

    As for updates we always release all the plugins together for major versions so when you see the Events Calendar 3.10 is available Pro would also have one available too.

    Thanks

    #937828
    rdall
    Participant

    This reply is private.

    #937836
    Brian
    Keymaster

    Sorry if you thought I was trying to be convinced if you have a license. That was not my point and I have access to that information. 🙂

    The license, which is in your account on theeventscalendar.com is not connected to your site so there are no update messages because the plugin first checks for a license and it is not finding a license in your site.

    The license field is in the Event Settings section on the License Tab, but in Multisite if you Network Activate The Events Calendar the License Field is in the Network settings section. If you are individually activating the plugin in Multisite the License tab will only show on the main network site.

    For more information about our licensing please review this page:

    https://theeventscalendar.com/knowledgebase/finding-and-inputting-your-license-key/

    We also have a variety of other articles related to licensing you might find useful:

    https://theeventscalendar.com/knowledgebase-category/install-licenses/

    #940376
    rdall
    Participant

    Sorry for the delay in getting back to you. I had to deal with other issues on the site.

    So if I am to remember you correctly. You want me to network activate your plugin across my entire network so I can add the license for pro so I can use it on one site?

    The chance of conflicts, not to mention menu items and functionality not required goes up exponentially when you network activate plugins you don’t need on other subsites.

    Look at what Gravity Forms, WooCommerce does with their plugins.

    Gravity Forms has implemented their add-on so that one version is dependent on a similar version.
    See Screenshot for an example: http://cl.ly/image/1K290Y2l3k28

    Also Gravity Forms uses a licensing system that allows me to license the product per subsite.

    Further more WooCommerce allows me to add my licenses to something called a Woothemes helper. This is just a licensing plugin that only allows me to add the plugins I need for WooCommerce. Yes I still have to network activate those plugins. But I don’t have to Network Activate WooCommerce for the licensed plugins to work. So I don’t have WooCommerce running on every subsite.

    Also I should mention that when I network activate addons for Gravity Forms or WooCommerce their isn’t any alerts promoting me to active the plugin on a subsite I don’t want to use their plugin on.

    I’ll add these suggestions to user voice but I though I would give you my feedback here as well.

    #940389
    Brian
    Keymaster

    Thanks for the feedback and the tweet it has been shared with the team and we are going to look into changing the process.

    I am going to close this ticket since there is nothing else we can do on it right now, but if you need anything else related to this topic or another please post a new topic on the forum and we can help you out.

    Thanks

Viewing 12 posts - 1 through 12 (of 12 total)
  • The topic ‘Javascript Error in The Events Calendar Pro 3.8.1’ is closed to new replies.