Issues with German translations in Filter Bar 3.12.1

[Oliver]

Hi,

in version 3.12.1 of the Filter Bar plugin I discovered some potential issues which I want to highlight here:

Textdomains
There are three textdomains used in tribe-events-filter-view-de_DE.po:
https://www.dropbox.com/s/xskup7y955ow16c/Screenshot%202015-11-14%2003.16.46.png?dl=0

a) Is the “default”-textdomain really needed? See line 294-298:

#: src/views/filter-bar/filter-view-horizontal.php:30
#: src/views/filter-bar/filter-view-vertical.php:30
#@ default
msgid "Submit"
msgstr "Abschicken"

b) Is the “tribe-events-eventful-importer”-textdomain really needed? It’s only used one time! See line 305-309:

#: the-events-calendar-filter-view.php:68
#, php-format
#@ tribe-events-eventful-importer

Putting HTML-elements inside an translation is not a best practice. Maybe this can be done more elegantly:

msgid "To begin using The Events Calendar: Filter Bar, please install the latest version of <a href="%s" title="%s">The Events Calendar</a>."
msgstr ""

Best regards,
Oliver

[George]

Hey Oliver,

Thank you so much for your reports of these issues. You have revealed several bugs here and in some of our other plugins. I’m really sorry that these bugs exist at all, but we have validated your findings and are working on fixes for all of these issues.

To keep things simple, I will consolidate all of your several threads into this one thread here: http://theeventscalendar.com/?p=1025546

Please post there for any more discussion related to these translation issues; I know normally we try to split issues into separate threads, but in this case it will just be simpler to stay coordinated in one single thread.

Check out that thread for my reply regarding these things.

I will close up this thread for now.

Thank you!
George

[Author]

Posts