Inaccurate documentation in source code for tribe_get_organizer_link()

Home Forums Calendar Products Events Calendar PRO Inaccurate documentation in source code for tribe_get_organizer_link()

Viewing 9 posts - 1 through 9 (of 9 total)
  • Author
    Posts
  • #55647
    Todd
    Participant

    The source-code documentation for the function tribe_get_organizer_link() – found in the-events-calendar/public/template-tags/organizer.php – says “Organizer Website Link; * Returns the event Organizer Name with a link to their supplied website url “. But i think that’s misleading – this function is for the Organizer’s page on this website, NOT “their supplied website url”. That’s done in a different function – tribe_get_organizer_website_link(). Right?

    #56011
    Leah
    Member

    Hi Todd,

    I apologize for the delayed response. We’re swamped with support requests right now, so we’re a bit behind our usual 24 hour guarantee. Someone will be looking at this post shortly to get you a more substantial response. I appreciate your patience.

    Best,
    Leah

    #56102
    Jonah
    Participant

    Hi Todd,

    No, the tribe_get_organizer_link() does what it says – it returns the organizers name linked to their supplied website. The tribe_get_organizer_website_link() will just return the link HTML, no name. Does that make sense or are you finding something different?

    – Jonah

    #56128
    Todd
    Participant

    i am seeing tribe_get_organizer_link() returns the Organizers name linked to that organizer’s permalink on MY website – the page that uses the Single-Organizer.php template. I am not seeing tribe_get_organizer_link() return a link to the organizer’s website, as entered in his cpt post.

    #56940
    Jonah
    Participant

    Hi Todd,

    You are right, I see the issue now. It seems to be it would work better if an organizer website is supplied to use that link and if not, default to the organizer permalink. I’ve created a ticket proposing this change, and at the very least get the code documentation corrected.

    Let me know if you need anything else with this.

    – Jonah

    #56944
    Todd
    Participant

    Thanks for following up on this Jonah. My 2-cents is that it works very nicely already, and the functionality should not change.

    Currently, in the Organizer meta-group, the Organizer’s NAME links to his permalink, and the Organizer’s WEBSITE (if provided) links away to his website.

    If the organizer-name also linked to his website, we’d have two links away to his website, and no links to his permalink page on my site (which nicely lists all his events).

    So my personal suggestion would be to simply update the documentation, and keep the current functionality.

    #56945
    Todd
    Participant

    And.. while we’re talking about the Organizer-Website Link …

    I wrote a little filter for that, changing the linked text to “See Organizer Website”, rather than displaying the full URL. In my case that url is often long enough to break my layout, since these meta-groups get only 1/3 of the page width.

    So again my 2-cents — i’d like to see an OPTION in the wp-admin (either globally, or per event, or per organizer?) to enter a custom string for the linked-text, rather than the full URL.

    #57142
    Jonah
    Participant

    Gotcha Todd, I’ll update the ticket to clarify this. If you’d like the extra organizer linked text, please submit your feature request to our Uservoice page: http://tribe.uservoice.com/forums/195723-feature-ideas

    Another option you could do before we would add that feature is use something like http://www.advancedcustomfields.com/ to add the custom fields yourself.

    Cheers,
    Jonah

    #979700
    Support Droid
    Keymaster

    This topic has not been active for quite some time and will now be closed.

    If you still need assistance please simply open a new topic (linking to this one if necessary)
    and one of the team will be only too happy to help.

Viewing 9 posts - 1 through 9 (of 9 total)
  • The topic ‘Inaccurate documentation in source code for tribe_get_organizer_link()’ is closed to new replies.