h1 tag empty on Events page

Home Forums Calendar Products Events Calendar PRO h1 tag empty on Events page

Viewing 10 posts - 1 through 10 (of 10 total)
  • Author
    Posts
  • #988729
    Mike
    Participant

    I installed Events Calendar Pro and it works awesome. I even like that my calendar shows up on the mydomain.com/events page. However on this page, my h1 title no longer displays. I want it to simply say Events, which is the name of the page in wordpress. All my other page titles work great. But on the Events page, with this plug in, the h1 is literally blank. The space for the title is there and everything, but the word “Events” doesn’t show.

    Can anyone help?

    thanks,
    Mike

    #988802
    George
    Participant

    Hey Mike,

    I’m glad The Events Calendar is working well for you, for the most part – this issue sounded theme-related to me at first, but then I noticed what you wrote here:

    I want it to simply say Events, which is the name of the page in wordpress

    When you say “the name of the page in WordPress”, do you literally mean that in the “Pages” section of your admin area, you have created a New Page and named it “Events”?

    If so, delete this page – The Events Calendar auto-generates an endpoint at the /events URL, sort of like a URL, so the “page” there is faked by The Events Calendar. Adding a real page with that name and slug can cause problems not unlike this one.

    I think the issue could still be theme-related, so if you do have an actual Page named “Events”, but removing doesn’t help, or you do not have a page like this to begin with, can you upload a .zip of your theme to something like Dropbox, or http://ge.tt, then share a link so we can download it? I’ll make a quick custom page template for you with “Events” hard-coded into the template, and then you can use this template on events pages which will hopefully help.

    Cheers,
    George

    #988815
    Mike
    Participant

    if i delete the page i made in wordpress called Events, do i delete it from the Menu as well in the main nav? And if I do that, do must need to make a custom link to the events page in the menu right?
    thanks for your help.

    Mike

    #988817
    Mike
    Participant

    here is a dropbox link to the theme.

    https://www.dropbox.com/s/ygntt8i5bmfw5al/soho-child.zip?dl=0

    thanks!

    #989459
    George
    Participant

    Hi Mike,

    Thanks for sharing that link! It unfortunately was a 404 Not Found error for me, though – https://cloudup.com/cOomsqP0xjg

    Can you try re-uploading and sharing?

    As for the deletion of the “Events” page you made, yes, deleting it from the menus would make sense since the page won’t technically exist any more (and, in fact, WordPress should auto-remove the menu once the page is deleted). You can indeed then add a custom URL item to the menus linking to the /events page.

    Thank you,
    George

    #992085
    Mike
    Participant

    Hi George,
    Try this link:

    https://www.dropbox.com/s/djoz3iubxnx2a7v/soho.zip?dl=0

    dropbox says anyone with the link can open, hope you can.

    Mike

    #992397
    George
    Participant

    Hey Mike,

    Thanks for sharing that. I have some good news and some bad news.

    The bad news is that this theme is unfortunately very, very poorly coded. So I cannot promise that my solution will work for you. With both the quality of this theme’s code in mind, along with our lack of “official” support for themes and custom code and all that, if this solution does not help then there’s unfortunately very little else we could do from our end on this.

    But now the good news, I guess – I’ve tried making you a custom page template. To use it, check out this Gist → https://gist.github.com/ggwicz/f82c2b13c41d0b8048d9

    Basically, you’ll want to make a new blank file in your theme called page-template-tribe-events.php

    Once this blank file is created, go to the “Raw” version of the Gist I shared above (which you can access right here → https://gist.githubusercontent.com/ggwicz/f82c2b13c41d0b8048d9/raw/8acff7a24d24c732944f8ee6301dc8d8d45ff61e/page-template-tribe-events.php

    Copy the entire text there – literally all of it!

    Then, paste it right into the blank page-template-tribe-events.php file in your theme.

    Save the file, ensure that is included on your site (via FTP or something), and then go to the “Events Template” option in Events > Settings > Display in your admin.

    In addition to the normal options like “Default Events Template” and “Default page template”, you should now see a new option called “Tribe Events Mike’s Template”.

    Choose that template, save your settings, and see if it helps with this at all.

    Cheers!
    George

    #992764
    Mike
    Participant

    very, very, poorly coded? This theme has been amazing for us and several web firms I respect. I am little freaked out now. We have 30 sites with this theme. I know this is not your job, but if you explain what you mean that would be great.

    I will check out what you have done. Thanks for the time.

    Mike

    #993087
    Mike
    Participant

    Hi George,
    Your template produced a title that was quite weird. But, the idea of making a new template for the Events page was what I needed. Took me a few minutes to make one that has the title exactly how i needed it.

    Thanks for your time,
    Mike

    #993644
    George
    Participant

    Thanks for the update Mike!

    I’m glad you were able to do a better job of coding the template than me – so perhaps take my admonishing of that theme with a grain of salt then! 😉

    But for the gist of why I mentioned it being “poorly coded”, for the most part I can see how it would work well for you and you certainly don’t need to replace all your dozens of sites overnight just because of my one opinion. However, there are some performance holes apparent in the theme:

    • a litany of dozens, perhaps more than a hundred even, it seemed, of get_post_meta() calls when just one would do.
    • poorly structured data
    • too much reliance on things in a global scope and just downright overly-complicated, fragile code. for one minor example, take a look at the barely-readable complexity used in this template file just to generate a page title!https://gist.github.com/ggwicz/e7750ec01ba93743d333

    Nothing is perfect, and if it works for you then it works for you! No snark or anything intended. Just some observations after diving into the code to help here.

    I appreciate your patience with the issue and your willingness to dive into the code yourself. Surely both traits will bode well for the future of this site and others – best of luck with all of them!

    Cheers,
    George

Viewing 10 posts - 1 through 10 (of 10 total)
  • The topic ‘h1 tag empty on Events page’ is closed to new replies.