ecp-page-template modifications

[Jim McClain]

I guess it’s a good thing I posted the source at pastie.org. The forum don’t like it when you post PHP. 🙂

[Jonah]

Hey Jim,

That all looks good to me, glad you figured it out! The code could be cleaned up a little for readability but bah, who needs that if it works right? Thanks for sticking with it and thanks for sharing your solution. Hopefully it will help others in the forum 🙂

If you need any other help just ask.

– Jonah

[Jim McClain]

Jonah said: “The code could be cleaned up a little for readability but bah, who needs that if it works right?”

Hey, I am all about clean code – as much as possible anyway. Are you talking about comment tags, or some actual code modifications that might be better? I sure don’t want anyone to inherit something that could be trouble later on. And sometimes the code that does something right can also slow the page load down a bit, whereas other code will accomplish the same thing, only it loads faster.

C’mon, hep a guy out – not that you haven’t already gone beyond the call of duty. 😉

Jim

[Rob]

Hey Jim. Sure thing; we all took the holiday weekend off to enjoy BBQ, but I’ve passed this on to Jonah to review today when he returns to the forum (to see what he can say about your last note there). Stay tuned!

[Jonah]

Hey Jim, the code works fine, there’s nothing actually wrong with it so I cannot help you clean it up. Mainly I just meant readability and comments which is pretty much subjective anyway.

Glad you got it working though and please let us know if there’s anything else you need help with.

Cheers,
Jonah

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Author]

Posts