dataTables.js conflict

[marilyn stookey]

Hi,
I’m having problems with the Event Calendar conflicting with another plugin – Our Team Showcase Pro on one page of my website. I’ve been told by Our Team Showcase that ” The plugin “the-events-calendar” appears to be loading a version of dataTables.js that is overriding the DataTables library from Our Team Showcase with one that does not include responsive tables” This is only an issue when viewing on mobile phones.

On mobile, the Event Calendar is overriding the Our Team Showcase’s layout. Is there a way to make sure the Event Calendar does not load on this one page?

This is the page with the issue (on mobile only): https://pennfield.wpengine.com/faculty-directory/. There is no calendar on this page. When I disable Event Calendar it looks correct.

The first screenshot attached is how it should look (when Events Calendar plugin is disabled). But when I enable the Events plugin I see a full table like the second screenshot.

Let me know if you need more info. thanks.

[marilyn stookey]

The correct screenshot is the one with the bullets to the left of the name (when Events Calendar is disabled). The screenshot showing the table with different font sizes is incorrect when Events Calendar is enabled.

[Cliff]

Hi, Marilyn. Thanks for this detailed report.

I have logged this issue with our developers and have marked this thread as Pending Fix, which means it should receive a reply once the applicable fix has been released. I cannot guarantee when it will be fixed as it’s in the development team’s hands now. They need to assign it, code it, test it, and schedule it for release.

I apologize for this issue and appreciate your understanding and patience.

[marilyn stookey]

Hi Cliff,
Thanks. Is there any quick / temporary fix that I could use? A snippet of javascript I could add to the page to make sure it uses the correct datatables script? We’re looking to launch the site very soon and I don’t want to launch until it looks correct.

[Cliff]

It comes from https://github.com/moderntribe/tribe-common/blob/4.7.9/src/Tribe/Main.php#L188, but I’m unsure if fully/always dequeuing it would cause problems because there are quite a few scripts with “datatables” in their handle…

I’m unsure how I can be of more assistance here. https://wordpress.org/plugins/debug-bar/ and https://wordpress.org/plugins/debug-bar-list-dependencies/ can be really helpful for detecting which scripts are loading.

[marilyn stookey]

Hi Cliff,
Could you give me a range of possibilities of when the fix might be out? I’m holding back on our site launch, hoping it will be fixed before we launch. Any chance of it happening within a week or two?
Thanks,
Marilyn

[Cliff]

The development team has historically been slow to change the versions of its third-party includes like this because of the QA required to make sure things don’t break within our own plugin suite.

I’d guess months at the soonest. I’ll poke them a bit on this for you to see if it’s something they can work in sooner than later. That being said, our development cycles are usually pretty structured and planned in advance so even if it got the green light, it’d still likely be a month at the very soonest.

[Cliff]

One of our developers came up with this untested code that may come in handy, either as the full drop-in solution or at least as a start for your own custom code using this as a starting point:

add_filter( 'tribe_asset_pre_register', function( $asset ) {
if (
'datatables' === $asset->slug
&& ! is_admin()
) {
$asset->slug = 'donotuse_datatables';
}

return $asset;
} );

Please let me know how this goes for you.

[marilyn stookey]

Unfortunately that didn’t do anything.

[Cliff]

Sorry to hear that, Marilyn. I’m not sure we can assist any further with this issue at this time.

If you need some coding help, you may want to ask that other plugin developer (which would be outside their normal level of support) or reference our documentation and list of known customizers.

[marilyn stookey]

Yes, considering their plugin cost $19 and I’ve paid you guys $178 for plugins I’m guessing the conflict is out of their range of assistance.

[Cliff]

Thanks for that added context. I pinged our development team and am hopeful this can be resolved within our next release or two (of course no guarantees).

I marked this thread as Pending Fix, which means it should receive a reply once the applicable fix has been released. I cannot guarantee when it will be fixed as it’s in the development team’s hands now. They need to assign it, code it, test it, and schedule it for release.

I apologize for this issue and appreciate your understanding and patience.

A workaround for now might be to actually change our plugin’s code itself — usually not recommended but in this case largely unavoidable and hopefully not to have to be completed over and over for forthcoming updates that don’t include this fix.

You could copy that plugin’s copy of datatables js and replace ours with it: /wp-content/plugins/the-events-calendar/common/vendor/datatables/media/js

This isn’t supported so if it doesn’t go well you’ll need to wait for the release. Of course, we always recommend restorable database and file backups as well as performing modifications first on a staging site before modifying anything on your live/production site.

Please let me know if you have any follow-up questions on this topic.

[Victor]

Hi Marilyn!

Just wanted to share with you that a new release of our plugins is out, including a fix for this issue 🙂

Find out more about this release → https://theeventscalendar.com/maintenance-release-for-the-week-of-6-may-2018/

We apologize for the delay and appreciate your patience while we worked on this.

Please update the plugins and let us know if the fix works for your site.

Best,
Victor

[Support Droid]

Hey there! This thread has been pretty quiet for the last three weeks, so we’re going to go ahead and close it to avoid confusion with other topics. If you’re still looking for help with this, please do open a new thread, reference this one and we’d be more than happy to continue the conversation over there.

Thanks so much!
The Events Calendar Support Team

[Author]

Posts