Bug in permalink generation

[aafhhl]

SInce we upgraded in 4.1.
In Event edit page and in Attendees page
the Permalink generated includes unwanted backslash \ character :

ex:
https://www.happyhumanlinks.ch/aaf\-events/soirees-decouverte-happy-human-links-3/
instead of :
https://www.happyhumanlinks.ch/aaf-events/soirees-decouverte-happy-human-links-3/

It gives 404 errors later on when post is displayed through revslider

The way to fix this bug in attendees.php file is to use this type of syntax :
esc_url( get_permalink( $event_id ) )
instead of :
get_permalink( $event_id )

Can you tell me where to apply equivalent fix to solve the problem globally at root cause ?

[aafhhl]

This problem occurs when unique event permalink slug setting is containing dash – character

[Geoff B.]

Hello again Christine,

We are sorry about the inconvenience this might be causing.

We did have a bug with permalinks that contained a dash character, but that was fixed a couple of versions ago. What is remaining is a bug that only impacts the back-end url, but not the actual front-end link. We are working on fixing that.

Unfortunately, I cannot commit to a release date at this point. But stay tuned you will be contacted as soon as it’s fixed!

But back to your situation, this is why my question from the previous thread is also relevant here. If you indeed have template customization in place, it might require some code updates to be up to speed with the latest version of our plugins.

That being said, I am not 100% sure that this is the cause, so I appreciate your patience while we try to find out the cause of the isssues.

With that in mind, I would also suggest trying the following:

• Go to WP-Admin > Events > Settings > Enable event views, in there leave just List checked.
• In the default view List should be automatically selected.
• Save Changes
• Re-test
• If it works re-enable all event views

Let me know how that goes.

Best regards,
Geoff B.

[aafhhl]

FYOI I always update my customized templates from very last orininal version and I have did than with 4.1 version.

I understood that the this slugs containing dash problem is a known bug

Tell me when it will be fixed.

[aafhhl]

Just a small hint for you :

I took some time to analyze your code
and found several cases of get_permalink function call not enclosed in esc_url function

[Geoff B.]

Hello again Christine,

Thank you so much for sharing your findings from your analysis.
I will relay them to the team in charge of the bugfix.

Also, I think it’s awesome that you are diligent in your efforts to keep all of your customizations up to date.

I hope I did not come off in a wrong way. I just want to make sure to leave no stone unturned as we try to get to the bottom of every issue (because it’s usually the fastest way to go) 🙂

So to summarize, you will be contacted as soon as the back-end permalink bug is fixed.

If I understand correctly what you are saying, revslider is using the back-end URL as a source. Can you confirm ? If that’s the case, I will see if I cannot ask Dev to provide a code snippet to fix that.

Have a great night!

Geoff B.

[aafhhl]

Hi,

Regarding Revslider I fixed the problem raised by the bad generation of event url by patching the revslider following file :

/wp-content/plugins/revslider/includes/slide.class.php

if(isset($this->params[‘enable_link’]) && $this->params[‘enable_link’] == “true” && isset($this->params[‘link_type’]) && $this->params[‘link_type’] == “regular”){
/* The original code is this line */
$link = RevSliderFunctions::getVal($this->postData, ‘link’);
/* Fixed by JRB for tribe Event url containing dash */
$link = esc_url( get_permalink( $this->id ) );
$this->params[“link”] = str_replace(array(“%link%”, ‘{{link}}’), $link, $this->params[“link”]);

As a think for this nice gift,

Please help me to solve the other problem with missing a href link in calendar view displayed on mobile !

Thanks

[Geoff B.]

Hello Christine,

Wow, that’s a really nice Easter gift! Thank you for sharing.

As promised before, you will be contacted when the backend URL bug is fixed.

Thank you for your patience in the meantime.

I will be glad to help you with the other issue in the other thread.

See you over there shortly.

Best regards,

Geoff B.

[aafhhl]

Hi,

I installed version 4.1.1 of Event calendar, Event calendar PRO, Event Ticket and Event Ticket Plus
and they does not fix this permalink generation bug if the url generated contains dash,
it still contain unwanted backslash character.

Do you confirm ?

[Geoff B.]

Hello Christine,

Yes you are absolutely right, the bug is not confirmed yet.

As promised, you will be contacted as soon as it is. According to what I can see the bugfix should be part of the next Maintenance release.

Thank you for your patience.

Best regards,

Geoff B.

[Geoff]

Hey there!

I just wanted to chime in and let you know that The Events Calendar 4.1.2 was just released and included a patch for this issue. Please update to the latest version when you have a chance and please let us know if you continue to have any issues with this or anything else down the road.

Thanks so much for your patience while we worked on this!

Geoff

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Author]

Posts