Broken update system

[Johan]

Both the free and paid upgrade plugins are incorrectly handling plugin updates. I’ve had three incidents now where the plugin upgrades have caused problems.

The first two were caused by the Event Tickets Plus plugin failing to undergo an automatic update. I did a quick scan through the files and couldn’t find the automatic update system to help with debugging it. If there is an automatic update system built in, just let me know where in the file system it is and I’ll assist with figuring out why it’s failing. If you don’t have one yet, then you need one 😉

The other problem was caused by the free plugin implementing a CSS change. This caused quite a drastic change to the styling of one of my clients sites and took a while to debug. The line of CSS which caused the issue was for .tribe-events-schedule h2 and involved setting it to inline-block. H2’s by default are set to block, so when you suddenly switched it to inline-block it was unexpected and caused problems. Where possibly you need to avoid setting any CSS in elements as it’s bound to cause styling problems in sites, and if you go implementing CSS and then changing it later then you are creating a double problem. I’m guessing this was an attempt to fix something for one situation, but you were forgetting that people already have this plugin installed and are not expecting the CSS to just change abruptly during an update. The CSS for this element also had the font-size set too. That didn’t cause a problem for my clients site, but I could imagine that breaking others sites though.

If you need assistance with any of this, please don’t hesitate to get in touch. I’m posting this under my clients account. There is no point in contacting them directly and I won’t receive any updates via email as this account is not registered with my email address. But I can be contacted directly.

Ryan Hellyer
Contact: https://ryan.hellyer.kiwi/contact/
Website: https://geek.hellyer.kiwi/

• This topic was modified 8 years, 5 months ago by Johan.
• This topic was modified 8 years, 5 months ago by Johan.

[Andras]

Hello Ryan,

Thank you for reaching out to us and submitting your findings.

If by automatic update system you meant that you get a notice when a new version is available, which then lets you run an update, we do have one in place.

Both the free and paid upgrade plugins are incorrectly handling plugin updates. I’ve had three incidents now where the plugin upgrades have caused problems.

Can you give me details on what exactly is handled incorrectly and what problems the updates have caused? If indeed there is an issue I would be happy to relay it to our developers so they can take a look at it.

Event Tickets Plus plugin failing to undergo an automatic update

It didn’t show there is an update? Or it started the update but the update failed? Was there an error message? What was it?

The other problem was caused by the free plugin implementing a CSS change.

Thanks for the headsup and sorry that this has caused issues. We’ll keep this in mind.

If you can share with me some more details of the above cases then I can try to help you solve them.

Cheers,
Andras

[Johan]

Sorry, I didn’t see your response until now (due to this not being my account I’m using).

Regarding the automatic updater, if you just point me in the direction of where it is in the code I can debug what is causing it to fail for me. There was no error message at all, it just looked like there was no auto-updater running at all.

From my inital post: If there is an automatic update system built in, just let me know where in the file system it is and I’ll assist with figuring out why it’s failing.

Can you give me details on what exactly is handled incorrectly and what problems the updates have caused?

When the Event Tickets and Events Tickets Plus plugins end up out of sync version wise, things tend to break. This happens every time I update the site running them, as only the Event Tickets plugin upgrades due to the issue mentioned above.

[Andras]

Hey Johan,

Sorry for the silence, I was out sick last week.

You can find the files responsible for updating in the following subfolder or the plugins:

common/src/Tribe/PUE/

When the Event Tickets and Events Tickets Plus plugins end up out of sync version wise, things tend to break.

Yes, that can happen. Event Tickets Plus is highly dependent on Event Tickets, so when we do some changes to one, the other needs adjustments as well. When we release a new version we announce it in our blog at the same time. There you can keep track of what the current versions are or what has been updated when.

Let me know if I can be of further assistance.

Cheers,
Andras

[Support Droid]

Hey there! This thread has been pretty quiet for the last three weeks, so we’re going to go ahead and close it to avoid confusion with other topics. If you’re still looking for help with this, please do open a new thread, reference this one and we’d be more than happy to continue the conversation over there.

Thanks so much!
The Events Calendar Support Team

[Author]

Posts