Home › Forums › Calendar Products › Events Calendar PRO › ajax-loading ID conflict between ECP and theme
- This topic has 4 replies, 3 voices, and was last updated 13 years, 10 months ago by
Jonah.
-
AuthorPosts
-
June 23, 2012 at 11:08 am #21108
Bob
ParticipantI’m not sure how to resolve this, but we’ve hit yet another global-namespace conflict between ECP and our theme. Both use a class of “ajax-loading” for a spinner type of animated gif, but where ECP explicitly uses an img and leaves the style for other attributes, the theme uses a background-image in its style (a different one, of course), along with some explicit sizing and locating.
I guess my resolution for now is to override the background image when the class appears in the particular location in the DOM that matches where ECP places it, but it seems like there must be some WordPress pattern here for keeping plugins and themes from stepping on each other? Like always use qualified style names like tribe-ajax-loading, maybe?
(Yes, I’ll be posting in the theme’s support forums too.)
– DougJune 23, 2012 at 11:46 am #21110Bob
ParticipantThinking (and digging) further, I hold you guys less at fault because it appears you don’t actually style that class/ID after all. The theme does. So I’m asking them to consider patching it to prepend a unique prefix to ensure not conflicting with plugins.
Still, you guys might want to consider that approach too so that themes and other plugins can’t break your behaviors either.
June 23, 2012 at 11:35 pm #21121Joyce Grace
MemberHi Bob, could you help us out by linking to your site and letting us know the name of the theme you are using?
Usually if this is something that doesn’t happen on the freshest version of Twenty Eleven theme it doesn’t have to do with our plugin. However, we know of some themes in particular that don’t mesh well with our plugin, and we are pro-active in working with theme developers out there and providing joint solutions to our users. For example, we have a specific tutorial on integrating Genesis themes with our plugin: https://theeventscalendar.com/tutorial-integrating-the-events-calendar-w-genesis/
At any rate, it would help to know the name of the theme and to be able to see your site 🙂
Thanks!
June 24, 2012 at 6:50 am #21128Bob
ParticipantTheme is LivingOS Xi. Forum post there, where they’ve agreed to look into changing their internal CSS ID:
http://themeloom.com/forums/topic/ajax-loading-id-conflict-between-xi-and-plugin/Our site is http://www.trinityfellowship.net
– Doug
June 26, 2012 at 7:56 pm #21226Jonah
ParticipantHi Bob,
I’ve added this as a proposed change in the future. Can’t guarantee it’ll get done but it’s been brought to our attention and I think it’s a good idea so we don’t conflict with the many themes and plugins out there. Thanks for bringing it up!
– Jonah
-
AuthorPosts
- The topic ‘ajax-loading ID conflict between ECP and theme’ is closed to new replies.
