[Jan]

Hey Geoff,
Nevermind, we decided that it’s also cool and functional to have a link to the Events Category, so we’ll keep it.

Thanks for your support.

[Jan]

Dear Geoff, thanks for your assistance.

While the second fix (to remove the Organizer link) worked well, I haven’t yet fixed the first point (removing the link to the category).

I created the folders properly following your instructions but when I use the details.php file with the modified lines 104-117, all the description boxes disappear and the post stops after the Google Kalender / Ical Export links (Please check attachment)

Any idea why?

Thanks in advance for your support.

[Jan]

This is your problem and there is a solution:

Issue with "preview" button when events cal pro is activated

[Jan]

@nico

Please try to get the fix in the maintenance release.

The fix is easy and quite clear – once you look at it.

And the bug suppose to have confusing effects.
I imagine that all people who have any kind of custom post type activated have to have that bug. But many won’t notice that it is caused by Event Calendar Pro.
I am a quite skilled programmer and it toke me about four hours to understand it’s Event Calendar Pro who mess it up.
People without programming skills won’t understand where the bug comes from. That sucks.

This is a bug that not only messes your plugin up, but a couple of other places :/

[Jan]

So this

// URL Arguments on home_url() pre-check
		$url_query = @parse_url( $post_link, PHP_URL_QUERY );
		$url_args = wp_parse_args( $url_query, array() );
		$permalink_structure = get_option( 'permalink_structure' );

		// Remove the "args"
		if ( ! empty( $url_query ) && '' !== $permalink_structure ) {
			$post_link = str_replace( '?' . $url_query, '', $post_link );
		}

		if ( ! $this->should_filter_permalink( $post, $sample ) ) {
			return $post_link;
		}

To

// Check if permalinks should be filtered first
if ( ! $this->should_filter_permalink( $post, $sample ) ) {
			return $post_link;
		}
// URL Arguments on home_url() pre-check
		$url_query = @parse_url( $post_link, PHP_URL_QUERY );
		$url_args = wp_parse_args( $url_query, array() );
		$permalink_structure = get_option( 'permalink_structure' );

		// Remove the "args"
		if ( ! empty( $url_query ) && '' !== $permalink_structure ) {
			$post_link = str_replace( '?' . $url_query, '', $post_link );
		}

[Jan]

It’s quite easy.

You have to check first if this Permalinks should be rewritten:

if ( ! $this->should_filter_permalink( $post, $sample ) ) {
			return $post_link;
		}

before delete some URL arguments

// URL Arguments on home_url() pre-check
		$url_query = @parse_url( $post_link, PHP_URL_QUERY );
		$url_args = wp_parse_args( $url_query, array() );
		$permalink_structure = get_option( 'permalink_structure' );

		// Remove the "args"
		if ( ! empty( $url_query ) && '' !== $permalink_structure ) {
			$post_link = str_replace( '?' . $url_query, '', $post_link );
		}

not the other way round.

So in ‘events-calendar-pro/src/Tribe/Recurrence_Permalinks.php’
Move lines 19 – 21 before lines 9 – 17

This solves the problem. This is not tested extensively – put it just make sense.

So – no I want to find out why this is executed on my post type.
Why even run code on other post types than your cpt.

The function ‘should_filter_permalink’ would check that – if it wasn’t to low in the ‘filter_recurring_event_permalinks’ – but why not check that sooner?

Please – this is a easy fix and don’t seem like a thing that has to be tested extensively.

Bring this in the new release.

[Jan]

The bug is in
events-calendar-pro/src/Tribe/Recurrence_Permalinks.php

I have searched for files that would make sense and found this file.
I overwrite it with the version of Event Calendar Pro 3.11
It works again.

There had been only a couple of changes.

I will sniff around a bit to maybe also can call you the line.

[Jan]

…the version of Event Calendar Pro bought is the most recent version.
So I am not able to downgrade – there is no other version available for me in the download section of my profile.

Is there a way to make (one) older verison(s) available for me?

[Jan]

Hm – this bug broke our site when the plugin was coupled with “redirection”.
I guess that might also happen for other users who have less technical skills than I have (and I had to search for some hour because of the combination of things).

I will deactivate ‘Events Calendar Pro’ till there is an update, I guess.

What would I buy by downgrade? Have there been security fixes in the update or only new functionality? Would be a pain to open a security whole that has been fixed through downgrade.

Do you have some first ideas what could cause the problem? I would be willing to put some effort in this and maybe there would be a possibility to ship a fix for the people who make their way to the forum.

I guess the broken preview is only an symptom and not the root of the problem.

As I recognized, the bug causes trouble with the ‘guid’ – so the feed is damaged because ‘guid’s are not unique.

[Jan]

I have about the same problem with a custom post type.

The preview button leads to something that would be correct if I wanted to make a preview of the frontpage.

When I save the post type, it acts like the front page. That has lead the “redirection” plugin to notice an URL change and put an 301 to the page.

I noticed, that no GUID is set for that custom post type. No, incorrect: The GUID is set to the front page = root URL of my page.

As the GUID is the front page and the preview is built of the frontpage I would guess that the URL of the page is (at least for some time) handled like the front page, and saved like the front page.

After publishing it, it is reachable through the URL like planed.

My problem is directly connected with the Events Pro Plugin.
It’s only there if the Events Pro is activated. It’s not there, when Events Pro is deactivated.

All the other Events Calendar Plugins and all other plugins have no effect on the problem.

I am very willing to help finding the problem.
I need my custom post type, I need noobs to be able to create such posts and I want to use Calendar Pro (as it is nice and I have payed for it).

I will have a look in the code myself but expect the team to help with it.
If you have some suggestion what to check out, test etc. Or if you are interested in my specific code – I am ready to help

[Author]

Posts