[timwakeling]

This reply is private.

[timwakeling]

Hi – thanks for getting back to me.

In answer to your questions:

I am using Events Calendar Pro v4.4.23 and The Events Calendar v4.6.11.1. I see a new version of each has come out yesterday but we do updates for this client on fixed days so I can’t update until next week.

The plugin is network activated (there are about 250 sites on the network).

We aren’t taking any action when the message appears, and as far as I know it doesn’t cause a problem on the site front end; it just clutters up the log by appearing repeatedly in there and getting in the way of seeing other log entries. I would say it’s a minor annoyance rather than a serious problem and I am tempted just to add an is_array() check to your function to get rid of it, as detailed investigation of the cause might be time consuming. 🙂

Tim

[timwakeling]

Thanks for your reply. Oddly enough, although it was consistently appearing when I wrote this, I can’t reproduce it now either. In answer to your questions, it did appear after an update, including reinstall of the plugins, and they weren’t customised. But I’ll close this for now and re-open if I see it again…

Tim

[timwakeling]

This reply is private.

[timwakeling]

Perhaps it was a momentary glitch, as I just went back there and downloaded successfully!

[timwakeling]

Update: the above code actually causes an error on pages whose links are NOT category specific, because it doesn’t handle WP_Error correctly. Here’s what I think the code should now be:
if ( $category ) {
$cat = get_term( $category, 'tribe_events_cat' );
if ( !is_wp_error( $cat ) ) $event_url = get_term_link( $cat );
}

[timwakeling]

Hi Brook – I’ve fixed this bug for you! To make this link go to the right category URL, just add the following at line 126 of widget-list.class.php, i.e. just before the comment /* Display link to all events */:


$cat = get_term( $category, 'tribe_events_cat' );
$event_url = get_term_link( $cat );


I have also modified line 131 to read:


_e( 'View all ' . $cat->name . ' events', 'tribe-events-calendar' );


But that’s optional, of course.

Hope that helps!

Tim

[timwakeling]

Hi – thanks for your response. You are right of course that it’s not directly your fault! But I thought I’d share with you the answer that I eventually found, in case you want to adjust your plugin to be compatible with Page Widgets.

Quite simply, the appropriate scripts are only being loaded on “widgets.php”, and Page Widgets needs to use them on “post.php”. To make this work as desired, I just modified line 18 of /events-calendar-pro/lib/widget-calendar.class.php from

if ( $hook != ‘widgets.php’ )

to

if ( $hook != ‘widgets.php’ && $hook != ‘post.php’ )

Now everything works. I realise that if you were to implement this you’d want to either detect the Page Widgets plugin and add this line if it is found (so as not to load the scripts needlessly), or alternatively add a tick box in your options along the lines of “Enable Page Widgets compability”, which would add this bit.

I doubt I’m the only user of this very handy page widgets plugin… 🙂

Anyway, I’ll leave it with you!

PS. Actually, I’ve changed my implementation to run your script loaders from my functions.php when post.php is detected, so that I can update your plugin later and not break things, but the above would be a clue to how you could do it your end if you wanted to.

[Author]

Posts