[Carsten]

This reply is private.

• This reply was modified 8 years, 5 months ago by Carsten.

[Carsten]

This reply is private.

[Carsten]

Solved the issue myself.

[Carsten]

No,

the issue is not resolved.

Full Screenshot

Carsten

• This reply was modified 8 years, 8 months ago by Carsten.
• This reply was modified 8 years, 8 months ago by Carsten.

[Carsten]

Hi Victor,

anything new about this issue and when it will be fixed?

Best Regards,
Carsten

[Carsten]

Hello Andras,

i waited for over a week and one more maintenance-release, again, that i had to patch by hand. Again. Till today i have no clear information how you will handle the problem.

I gave Information about the problem 3 weeks ago and solved it (in my opinion) 13 Days ago.

To have no clear information 13 Days after i supplied you the explanation of the problem, at least, AND a possible patch, is very disappointing.

A second support-ticket is open (The Events Calendar throws php warnings on every request on the network area on a normal multisite-network and spams with php-warnings) for several weeks and i got no clear information here also.

So, yeah. I’m sorry for being disappointed, but do you think the case works well?

Best Regards,
Carsten

[Carsten]

Hi,

the Issue isnt resolved in the todays Update. When will there be a Patch for that?

Do you need any assistance?

Best Regards,
Carsten

[Carsten]

Hi,

i am pretty irritated, that you had not fixed this issue with the today Update.

How many times will we have to fix this again after you sent an Update? Because with the todays update our customers experienced the above decscribed problems again.

I am really not satisfied how this Issue went.

Best Regards,
Carsten

[Carsten]

Hi,

i changed the maybe_get_min_file-function from relying on the wp-content-folder to using the actual location of the event-calendar-plugin. Pretty simple. Free feel to use it!

/**
	 * Returns the path to a minified version of a js or css file, if it exists.
	 * If the file does not exist, returns false.
	 *
	 * @since 4.3
	 *
	 * @param string $url   The path or URL to the un-minified file.
	 *
	 * @return string|false The path/url to minified version or false, if file not found.
	 */
	public static function maybe_get_min_file( $url ) {
		$urls = array();
		// If need add the Min Files
		if ( ! defined( 'SCRIPT_DEBUG' ) || SCRIPT_DEBUG === false ) {
			if ( substr( $url, - 3, 3 ) === '.js' ) {
				$urls[] = substr_replace( $url, '.min', - 3, 0 );
			}

			if ( substr( $url, - 4, 4 ) === '.css' ) {
				$urls[] = substr_replace( $url, '.min', - 4, 0 );
			}
		}

		// Add the actual url after having the Min file added
		$urls[] = $url;

		// Check for all Urls added to the array
		foreach ( $urls as $key => $url ) {
			//set path to file for Windows
			$file = $url;
			
			//Set variable for plugins normalized directory
			$normalized_plugin_dir = wp_normalize_path( dirname(TRIBE_EVENTS_FILE) ) . '/';
			$plugin_url = plugin_dir_url( TRIBE_EVENTS_FILE );
			
			//Detect if $url is actually a file path
			if ( false !== strpos( $url, $normalized_plugin_dir ) ) {
				// Turn file Path to URL in Windows
				$url = str_replace( $normalized_plugin_dir, $plugin_url, $url );
			} else {
				// Turn URL into file Path
				$file = str_replace( $plugin_url, $normalized_plugin_dir, $url );
			}
			//if file exists return url
			if ( file_exists( $file ) ) {
				return $url;
			}
		}

		// If we don't have any real file return false
		return false;
	}

[Carsten]

Hi András,

Meanwhile I also had a conversation with one of the developers and told me that if the content folder was moved / renamed “as it should be”, then the plugins should work.

No. We didn’t move the wp-content-folder, but the Plugins-Folder! Thats possible too, have a look:
https://codex.wordpress.org/Editing_wp-config.php#Moving_plugin_folder

Best Regards,
Carsten

[Carsten]

Hi András,

we changed the last return false to a return $url, what fixes the problem on our multisite network for the moment.

It would be great if you would fix the problem with your next update, so we dont have to edit the Assets.php everytime an update is published…

I saw now possibility to fix the problem without changing your Plugin-Code.

So now you aren’t able to see the problem on the site we have provided, but it still exists on a unchanged Plugin and is documented above.

Best Regards,

[Carsten]

Hi András,

today i had a deeper look into your code and i think i found the problem.

The function maybe_get_min_file (common/src/Tribe/Assets.php) seems to rely on the Plugin residing in the WP_CONTENT_DIR. But this is not mandatory. You can move the plugins-Folder to any place you would like in a wordpress-Install (like we did).

Here is the Documentation about moving the plugin-folder: https://codex.wordpress.org/Editing_wp-config.php#Moving_plugin_folder

Here you see, that the plugin-Folder does not have to be in the WP_CONTENT_DIR!

In my case the $file in the function is not converted to a path, the following file_exists fails und the maybe_get_min_file returns a false, which results in the javascript not loaded.

Did you get what the problem is? Is there anything we can do to assist you any further?

This is a pretty big issue at the moment and it would be great to fix this as soon as possible!

Thanks.
Carsten

[Carsten]

Hi András,

all three Countrys are whitelisted now. You should be able to login now.

Thanks for your support!
Carsten

[Carsten]

Hi András,

can you tell me the country you log in from?

More and more Customers get aware of the problem and it would be really good to know if you can support us with a fix for this problem!

Thanks.
Carsten

[Carsten]

Ah sorry! Our WAF blocks access to the /wp-admin/ from outside central europe. All our customers come from Germany.

Where do you log in from? I can put any Country on the whitelist in a minute.

Thanks for your help!
Carsten

[Author]

Posts