[Grégory]

Hi again.

BTW, there are a lot of errors related to i18n, like that:

_e( 'Organizer Name' , 'tribe-events-community' ); ?>:

Should be:

_e( 'Organizer Name:' , 'tribe-events-calendar' ); ?>

“:” should be inside the string to translate.
Moreover, the translation with “:” already exists in TEC, so it should be used.

Bye

[Grégory]

This reply is private.

[Grégory]

You’re welcome 🙂
Warn: there’s a missing closing parenthesis in my function get_ical_link() (a non-closing empty() :s).

[Grégory]

Hi Rob, thanks for your answer.

Since I don’t get any 404 (I made lots of changes so…), this code is not tested, but it should do the trick I think: http://pastebin.com/qumtFVk3

“Thanks for your patience on this end so far.”
No problem, I do my stuff myself, I can’t stay put 🙂

BTW, I saw that the url for the iCal link is always the same, whatever we’re seeing a category, a tag, a single event, and whatever the view.
So… http://pastebin.com/2huAPHyv (the version I use for my client is a bit different but it works, I guess this one should too). Maybe some new rewrite rules are needed for this to work, I’ve added a few ones for my needs.

Cheers.
Greg

[Grégory]

Hi there.

I just found something interesting.
– Main events page (example.com/events/month/), month view: 8 events, 83 queries.
– Category archive (example.com/category/foobar/month/), month view: 5 events, 247 queries.
– Tag archive: not tested. I probably messed something, I have a 404 ^^ (I don’t use them).
– Organizer page (example.com/organizer/john-smith/month/), month view (yes, I managed to find a way to have the views on organizers page): 3 events, 78 queries.

So, there’s something about the category archive here… :s

Cheers.
Greg

[Grégory]

Hi Tim,

Thank you, and to all the team for your hard work.

If I have enough time before the end of my project and if the things are not getting better before that, maybe I’ll take a look to it. For my client needs I had to do a special administration page with the events displayed by month and venue (screenshot: https://www.dropbox.com/s/85i2e10escyhw9g/Screenshot%202013-07-26%2021.44.21.png ). The whole page uses only 27-28 queries to display a month (for the other months I use ajax, way faster, but it works without it). The basic idea is to launch only 1 query to get all events in a month, and use a single loop to print them all (and filling empty cells). Maybe I can use a system quite similar for the front-end month view. Now, if we have lots of events… I don’t know which way is the better. Maybe there’s something to do with the integrated plugin cache system (I didn’t use it, not enough time to learn how it works, and I didn’t feel I needed it in this case).

Anyway, your dev team is in a better position than I am to know what to do (and I’m not a hight skilled developer either).

Regards,
Greg

[Grégory]

Hi Barry, thanks for your answer.

The month display can be used for the whole calendar, or for the ‘tribe_events_cat’ archive (when you display events of a specific category).
The code above forces $query->is_post_type_archive to true when the view is ‘month’, even when the ‘tribe_events_cat’ archive is displayed.
Lots of filters use this state ($query->is_post_type_archive = true) and as a result, return wrong data.
Few examples:
– is_post_type_archive() will return true, and shouldn’t.
– the filter ‘post_type_archive_title’ will be triggered, and shouldn’t.
– in a real post type archive, get_queried_object() contains a post type object. In this case it will contain the taxonomy term array (same problem for get_queried_object_id() of course).
– etc.

Sorry if I was a bit harsh with my previous post(s), I know it’s a major release and it always comes with bugs, and you are doing your best, as fast as you can. But the deadline for the website I’m building is approaching very quickly and I’m feeling like losing my time, fixing bugs.

Regards.
Greg

PS: in my case anyway, removing the filter solved my problem.

[Grégory]

Thank you Casey.
(even if it’s not a functionality request, but a bugfix)

Regards.
Greg

[Grégory]

Hi again.

$wp_query in a taxonomy page:
https://www.dropbox.com/s/79vc9mtdlfey0ua/Screenshot%202013-07-24%2000.25.42.png
Don’t you think there’s something wrong here?
/the-event-calendar/lib/tribe-event-query.class.php:
http://pastebin.com/zsrCxXbg
Simply get rid of all of it, it’s useless, WP is already doing this itself (and it messes with the url rewriting).
Or, if I correctly understand the first comment, “eventCat” was the old slug of the taxonomy. In that case:
http://pastebin.com/tDRQLQKG

Done, the “WordPress won’t rewrite it” problem is solved. You’re welcome.
See you.

[Grégory]

Hi Casey, thank you for your answer.

OK for the URL rewriting, I’ll take a look myself, there must be a way, they simply are taxonomy term and post type parameters after-all (if we forget the eventDisplay parameter).

Regarding the excessive amount of queries, I can provide you an url but I think it won’t help much: the site is in its development phase, so not really online (but reachable from outside). It is on my personal server (on my NAS), which is quite slow. So this information won’t be relevant imho. I only can say the month view is a bit slower than the others. So far, I have less than 10 events per month.

BTW, I found something else yesterday: in an organizer page, the “default view” setting is not applied. For example, even if I’ve set the “month view” as the default view, I land on the list view anyway when I visit an organizer page.
I don’t know if it’s a bug or done on purpose, but here is my “fix”: http://pastebin.com/1DC2hfYW

Tell me if you still want an access the site.
Thank you.

[Grégory]

Edit : oops, my php code has been kicked ^^
“- In a month template, paste this at the bottom of file (footer, whatever):” echo get_num_queries().’ queries. ‘;

[Grégory]

Hi.

I ran the same problem and found where it is. It’s located in ‘/events-calendar-pro/events-calendar-pro.php’ and only in 2 places. Everywhere else it’s fine, it’s a “typo” 😉

[Grégory]

Thank you Jonah (in my case it’s not a problem, since I use the PRO version).

Greg

[Grégory]

OK, some news.
It seems this one is more vicious than I thought.

Steps I followed:
– The basic version only is activated, not the PRO.
– Create a new event (2013-07-15 09:00am to 2013-07-15 11:00am) and save. Look the dates, it’s good.
– Go to the front-end single view: the end date is the current day+time. Printing the post object will show what I mentioned earlier: the EventEndDate field is empty, or filled with “July, 15th 2013 11h00min” (should be “2013-07-15 11:00:00”). As a result, the current date is displayed in the page (“July, 15th 2013 11h00min” can’t be passed through strtotime() a second time, it will return false).
– Go back to the event edition, change the end hour to 01:00pm, save.
– Go back to the front-end single view. The current date is still displayed, and the EventEndDate field is now empty or filled with “July, 15th 2013 13h00min”. OK, this the good hour, but still the wrong format.
– Activate the PRO version.
– Go back to the front-end single view. Nothing new, the end date is today and the EventEndDate value hasn’t changed.
– Go back editing the previous event. Save (no change, still 2013-07-15 01:00pm).
– Go back to the front-end single view. Now it’s good! EventEndDate contains “2013-07-15 13:00:00” everywhere and display the good date in the page \o/

Conclusion:
The end date seems to be correctly saved (somewhere) with the basic version because when you edit an event, you can see it, this date is good. But, I think a step is missing because if we save this event with the PRO version, it’s all right.

Good luck with this ^^

[Grégory]

Hi Jonah,

Thanks for your answer.
No problem, major updates come with some bugs, as a developer myself I totally understand.

To be more specific:
File: /wp-content/plugins/the-events-calendar/public/template-tags/date.php
Method: tribe_get_end_date() (starting at line 60)
Tested with and without the PRO version.
Tested with and without other plugins activated.
Tested with my homemade theme and TwentyTwelve.
No template overrides, no other “event” Custom Post Type, no modifications to existing templates.
My print_r() test was at line 70, right before this “if” statement:
if( empty($event->EventEndDate) )
In short, the plugin is a fresh installation and I’m in the “discovery phase” (first time I use it), so the only modification I made was this test, after discovering the bug.

So far, I created only 1 event. I’ll try with a dozen and come back for my feedback.

Thanks.
Greg

[Author]

Posts