Forum Replies Created
-
Posts
-
WP SEO unhooks the default rel_canonical function as well.
Short of fixing the underlying issue, we’re stuck with band-aids for now. Stay tuned… we hope to have a fix soon.
They should, but when the $post is populated with the first event, is_singular() is true…
Stijn,
We’ve added a filter to 2.1 — you can ask Rob for a copy of the dev branch once he’s tested it.
Adding this code in your functions.php or a plugin should do the trick (once you have the new ECP code):
add_filter(‘tribe_ical_feed_item’,’tribe_add_attachment_to_ical’, 10, 2);
function tribe_add_attachment_to_ical($item, $event){
$args = array(
‘post_type’ => ‘attachment’,
‘numberposts’ => -1,
‘post_status’ => null,
‘post_parent’ => $event->ID
);$size = ‘full’;
$attachments = get_posts($args);
if ($attachments) {
foreach ($attachments as $attachment) {
$image_attributes = wp_get_attachment_image_src($attachment->ID, $size);
$item[] = “ATTACH:”.$image_attributes[0];}
}return $item;
}Change the $size variable if you don’t want the full size image — check the codex for options.
Well, a partial fix for the titles — it works in the older breadcrumbs plugin, but not the WP SEO one. Joey seems to have an idea on how to fix it. For now, “we hope to fix this in 2.1” is the best answer I can give.
Both issues seem to be related to the fact that that there is not actually a post or page that exists for the calendar grid view, upcoming view, past view, etc. This throws some themes and plugins for a loop. We’ve made steps to address that but haven’t fully solved all the issues yet.
I’m seeing the canonical bug and the title/breadcrumb bug in the current Events 2.1 branch so we haven’t fixed those quite yet, but I think I have the title/breadcrumb bug fixed on my local dev site. The canonical bug is much harder to squash…
Well, this is one of those situations where there is not one solution.
For example, if there is a featured image, is that the attachment? Do we attach all items attached to that post including the featured image? (e.g. a PDF, images in the post body, etc). There’s not a clear 1:1 mapping of WP attachments to iCal attachments, and including all attachments (esp. base64 encoded) could seriously bloat the iCal export (and cause performance issues on busy sites).
A filter allows the user to make those determinations themselves, but does require some PHP skills.
A more fully fledged feature will probably have to options to configure attachment behavior, but that takes time and discussion… and 2.1 is in feature freeze. Sorry!
Nope, that’s definitely the way to go. I just wanted to know the specific use case as we determine how/when to implement it as the ‘common’ clients don’t seem to support remote (only local) attachments.
If you need an immediate solution, you can add a filter to the ical generation in the iCalFeed() method in events-calendar-pro.php to inject an attachment tag & URL into the iCal feed (based on the event ID).
I think this is going to get on our roadmap, but not for a bit yet (looks like 2.2 at the moment).
Stijn,
Can you give us some context for how you’re using the feed? I ask because your example uses URLs for the attachment tag which don’t seem to be supported by iCal or Outlook.
Marco,
I was able to replicate the issues you’re seeing above after changing the language on my test install (running the same code Rob sent you) until I rebuilt/flushed my permalinks. After that, /passato/, /mese/, and /locale/ all worked fine (as I suspected as the English permalinks are working for you… because those were built before the language was changed/patched code was installed).
If saving your permalinks is not causing them to be flushed, you can try:
Deactivating and reactivating the Events plugin (the free one, not PRO).
Adding this to functions.php:
global $wp_rewrite;
$wp_rewrite->flush_rules();Make sure you remove that after it’s working or you’ll flush your rules on every load, which will really slow down your site.
PS- ‘upcoming’ is empty in the Italian language files, so it’s not being translated. The rest are, so they are being translated. It threw me for a bit, so I wanted to note it here.
Rob- we will probably want to address that in the 1.2 language updates, unless that’s correct? Google Translate says ‘imminenti’ but that may be way off.
If you want a version that supports recurring events, the feature request forum would be the place to note that so it can get on the roadmap for a future release.
Here’s a patch you can use until 2.0.3 is released:
https://theeventscalendar.com/patch-for-the-events-calendar-2-0-2-date-bug/
Peter,
Yes that’d certainly be the most elegant solution. Have you suggested that in the feature requests thread?
Terrance,
Are you comfortable adding folders/files to your theme and editing PHP? If so, I could write a walkthrough, but it’ll take a few steps to get this working as the link is hardcoded in the table (and list) view, and there’s currently no easy way to target those links via CSS or JQuery (based on event specific meta data, at least).
Can we get some info on the themes you’re using (for those getting the error)? If there’s a common thread there it might point to the issue.
From what I can see, it’s probably something related to the $post object getting unset (or set to a non-event) somewhere in the page template before tribe_get_start_date() is called.
