Home › Forums › Calendar Products › Events Calendar PRO › Update doesn't fix missing Time and Date in Details Section
- This topic has 26 replies, 6 voices, and was last updated 10 years, 1 month ago by
Geoff.
-
AuthorPosts
-
January 6, 2016 at 5:19 pm #1051513
Brook
ParticipantI appreciate the feedback as well, it’s good to know this has affected multiple people. Unfortunately it is not reproducible on the vast majority of websites (so far only two we’re aware of). I have been trying to reproduce this locally all along, no dice. And you can see in the numerous sites in our showcase and even our own demo site that it’s not happening with recurring events.
There is something unique about your two sites or servers causing this. And in order to find what that is we will need to do a full conflict test as outlined above. Make sure to try switching themes alongside disabling plugins as outlined in the article (conflict test), sometimes two or more things can cause the same problem and disabling only one of these will not cause it to go away.
I understand that this takes time, and I am sorry that it has become our necessary next step. This is not a simple CSS issue like before. The time is completely absent from the HTML. Without a time in the HTML no amount of CSS will make it visible. That’s why we now need to do a conflict test.
Please let me know how it goes or if you have any more questions. Cheers!
– Brook
January 6, 2016 at 6:28 pm #1051534Kurt
ParticipantThis is a new site and not in production, so I did a “scorched earth” test and uninstalled WordPress and installed it again. I have Softaculous, so this only took a couple of minutes. The operating environment is CentOS 1.7, WordPress 4.4, default Twenty Sixteen theme.
I installed The Events Calendar, and added a single event and a multi-day event. They both showed the dates and times properly: Date and start and end time for the single day event, start and end dates and times for the multi-day event.
I then installed TEC pro and added a recurring event. As before, the Details showed the date, but not the times. I tried the Twenty Fifteen and Fourteen themes with the same result.
Here’s where it got interesting. I noticed that there weren’t any previous/next month navigation controls, and was trying to figure out how to get to the next month. I finally found the “Events In” control and was able to display February. I selected the recurring event… and the Details included the start and end time. I went back to January… no times shown.
I created two more recurring events, one starting in December 2015, and one starting in February ’16. In both cases, the time was missing on the first event, and was present on all subsequent events.
So it looks like this is a “first time” bug. I suspect that laughmasters and I are seeing it because we’re creating new events and seeing the first event. Someone upgrading the product won’t see it on existing events because the first event is in the past.
~~ Kurt
January 6, 2016 at 7:23 pm #1051570laughmasters
ParticipantI can also confirm that the issue is only on the first event of a series of recurring events.
i.e. first event: no time in the details section. subsequent events: time shows up.-
This reply was modified 10 years, 3 months ago by
laughmasters.
January 7, 2016 at 4:30 am #1051663Jenna Naylor
ParticipantHello,
I can confirm the behaviour that laughmasters and kurt are seeing. The site we’ve been working on is a new build. Added the Event Calendar Pro plugin late December. You can see the first occurrence of both events on the timetable here have no time showing under details http://dev.kitestudios.org/class/adult-pottery-studio-mon-pm/2016-01-11/
-Pundarik
January 7, 2016 at 11:55 pm #1052312Brook
ParticipantThank you guys, all three of you. Obviously this is a bug. I faithfully followed Kurt’s steps to reproduce this, but still am not see the same thing on my end. I have recreated some of your problem events exactly without issue.
But three people seeing it obviously trumps my not seeing it. I am going ahead and logging this bug. From there our devs will try to reproduce it, and find a fix. Then we can release an updated version of The Events Calendar without the bug.
While you wait for a plugin update with a fix though, it should be possible to work around this. The event time is showing higher up on the page in the title. If we copy the code that power that lower on the page, then we have a workaround/hack to fix this. To do this you would create a theme override by following our Themer’s Guide. Specifically the file to override is: /wp-content/plugins/the-events-calendar/src/views/modules/meta/details.php
Starting on about line 33 through line 94 is the code that shows the event time and date. You could comment out or delete this for now. Then replace it with:
tribe_events_event_schedule_details( $event_id, '<h3>', '</h3>' );That will add a one line version of the time and date, just like appears at the top of the page.
Or if you prefer you can just wait on a plugin update.
Does that all make sense? Will that work for y’all? Please let me know.
Cheers!
– Brook
January 8, 2016 at 8:51 am #1052650Kurt
ParticipantThis has just become more bizarre. I deleted all the test events I had set up and started doing some more work on my site. I installed Community Events, and then realized I wanted the Filter Bar too so I bought and installed that. After doing some configuration I started adding some events, and when I added a recurring event the detail page is not showing the date or the time on any of the events.
I’m going to do another “burn it to the ground and start over” today, I’ll let you know what happens. I was going to try to find where this page is displayed, so now that I know I can take a look and try to put some diagnostic code in.
More technical info: my server is running PHP 5.5.3, although I doubt that’s significant.
~~ Kurt
January 8, 2016 at 9:43 am #1052701Kurt
ParticipantI did a complete reinstall and now the code is behaving as before… only the first event is missing the time.
I took a look at the code and I just don’t know enough about PHP and WordPress internals to work through the code. I did try a few things, like a multi-day recurring event, and the dates and times were formatted correctly. From what I can see in the code, it looks like the problem is in the single day event block, which uses variable $time_formatted. I may play around with that a bit.
I’m using TEC to replace another calendar program on this site, and we’re planning to cut over in February. So for now I’m just going to tell the event managers to start their recurring events in December ’15. I expect most visitors won’t navigate backwards on the calendar.
January 8, 2016 at 10:04 am #1052717Kurt
ParticipantI changed line 112 in details.php from: <?php echo $time_formatted; ?> to: <?php echo $start_datetime; ?>
When I displayed the event, it did show the start date and time. So the problem appears to be in whatever code sets the $time_formatted value.
I worked up a hack that rebuilds $time_formatted from $start_datetime and $end_datetime. Find this code at about line 110 in details.php:
<dt> <?php echo esc_html( $time_title ); ?> </dt> <dd><div class="tribe-events-abbr updated published dtstart" title="<?php esc_attr_e( $end_ts ) ?>"> <?php echo $time_formatted; ?>Add the hack code so as below:
<dt> <?php echo esc_html( $time_title ); ?> </dt> <dd><div class="tribe-events-abbr updated published dtstart" title="<?php esc_attr_e( $end_ts ) ?>"> <?php $hack_start_time = explode(" @ ", $start_datetime); $hack_end_time = explode(" @ ", $end_datetime); $time_formatted = $hack_start_time[1] . " - " . $hack_end_time[1]; ?> <?php echo $time_formatted; ?>So far this working in all my tests.
January 10, 2016 at 12:41 pm #1053589Kurt
ParticipantOkay, this is getting really frustrating. I cleaned up my site, added my Venues, added my Organizers, and added my Users. I signed in as a user and entered my first “real” event, a recurring event that occurs twice a month. I displayed the calendar and none of the events are showing the date or time. Not just the first event, all of them.
I’m just going to hack the details.php module to not display the date and time at all. It’s in the event header anyway, and I can’t spend any more time on this. I’ll wait for a patch. If your developers need to see this in action put them in touch with me and I can set up a test system for them.
January 11, 2016 at 10:25 pm #1054309Brook
ParticipantWow Kurt, thanks for sharing every step you’ve tried. Sorry this has been an intermittent pain, those are the hardest to troubleshoot. I’ll pass the info along to our developers. Thanks again!
- Brook
February 18, 2016 at 8:34 am #1076694Support Droid
KeymasterThis topic has not been active for quite some time and will now be closed.
If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.February 18, 2016 at 9:54 am #1077153Geoff
MemberHey there!
Just wanted to jump in here and let you know that we released The Events Calendar 4.0.6 last night and it included a fix for this issue. Please check your WordPress updates, or you can also grab the latest copy over at WordPress.org.
Thanks for your patience while we worked on this! Please feel free to open a new thread if you continue to experience the same issue or have any other questions that pop up during updating and we’d be happy to help. 🙂
Cheers!
Geoff -
This reply was modified 10 years, 3 months ago by
-
AuthorPosts
- The topic ‘Update doesn't fix missing Time and Date in Details Section’ is closed to new replies.
