Term Not Updating in Translation; Same Title and Placeholder Term

Home Forums Additional Help Translations Term Not Updating in Translation; Same Title and Placeholder Term

Viewing 4 posts - 1 through 4 (of 4 total)
  • Author
    Posts
  • #1040290
    Sean
    Participant

    Hi,

    We are changing various terms in the plugins by creating en_US.po and en_US.mo files for the respective plugins. However, we have been unable to update a few terms.

    1. Filter Bar: “Submit” (button text)
    We’ve entered a translation, but anything we enter as the new term doesn’t appear in the filter bar. We can change line 30 in /the-events-calendar-filterbar/src/views/filter-bar/filter-view-vertical.php from <input type="submit" value="<?php esc_attr_e( 'Submit' ) ?>" /> to <input type="submit" value="<?php esc_attr_e( 'Find Events' ) ?>" /> but that obviously will be overwritten every time the plugin is updated. Any ideas why the translation for this string isn’t taking effect when all of our other translated terms are?

    2. In the Tribe Events Bar, the same string that is used for the “Search” header is also used for the “Search” field’s placeholder text. How can we edit the placeholder text to something different than the title?

    Thank you.

    #1041073
    George
    Participant

    Hey @karly,

    It unfortunately seems that these strings do not have The Events Calendar’s text domain included in it, thus making it hard to translate them with default methods. In other words, this:

    <?php esc_attr_e( 'Submit' ) ?>

    Should really be this:

    <?php esc_attr_e( 'Submit', 'the-events-calendar-filter-bar' ) ?>

    This is something that unfortunately cannot be fixed until the plugin is updated next at the earliest 🙁

    Thank you for revealing this bug to us! I’m sorry that it cannot be fixed immediately but it will be fixed eventually for sure.

    — George

    #1041281
    Sean
    Participant

    Hi George,

    Okay thanks for confirming. We’ll just edit the source code in the meantime.

    Regards,

    #1041721
    George
    Participant

    Sounds good @Karly – please note, however, that any source code edits will likely be lost the next time you update the plugins on your site. Just wanted to remind you!

    Cheers,
    George

Viewing 4 posts - 1 through 4 (of 4 total)
  • The topic ‘Term Not Updating in Translation; Same Title and Placeholder Term’ is closed to new replies.