SEO title error since 3.5 (Part III)

[Lars]

@Barry: As you closed our thread (again) before we had a chance to reply – we just need to point out what must be the facts and learning of this process and the solution we found.

In relation to this:
// Runs the <title> element through our custom filter
// add_filter('wp_title', 'filter_events_title');
// If you are using Yoast delete the above line and uncomment the following one
// add_filter('wpseo_title', 'filter_events_title');

You have apparently in 3.5.1 (without knowning?) made “Map View” page compatible with Yoast SEO plugin as this code line:
add_filter('wp_title', 'filter_events_title_map');
make the custom title show on “Map View” where as this:
add_filter('wpseo_title', 'filter_events_title');
is still needed to make custom title show for both “Week View” and “List View” which are then apparently still not compatible with Yoast SEO? How else is this logic as it stopped working with updating to 3.5?

Just to clear things up… hoping that one day all of ECP will work with Yoast SEO.

[Barry]

Hi Lars,

Thanks for your update.

I think it’s important to note that if you want to integrate two different plugins – ie ours and one made by a different vendor – then that is a responsibility you are taking on.

With or without that plugin, this code behaves exactly as I would expect:

add_filter( 'wp_title', 'filter_events_title' );

function filter_events_title( $title ) {
	$list = tribe_is_list_view();
	$map = tribe_is_map();
	$week = tribe_is_week();

	if ( $list ) $title = ' LIST VIEW! ';
	elseif ( $map ) $title = ' MAP VIEW! ';
	elseif ( $week ) $title = ' WEEK VIEW! ';

	return $title;
}

If for whatever reason you need to change the hook to wpseo_title (and what you are describing sounds to me like a result of an ajax refresh on the map view page) then you need to also engage and make use of the wp_title hook accordingly.

These are quite simply integration issues, though, and though you are more than welcome to post any workarounds you find and ask for a pointer in the right direction I would like to make it clear that they do not represent bugs as such.

[Lars]

Did you test that code you just posted? As I state – with Yoast SEO installed your code only works for “Map View” (writing out “Map View” as browser window title) and not for “List View” or “Week View” unless using:
add_filter( 'wpseo_title', 'filter_events_title' );

[Barry]

Did you test that code you just posted?

Yes – I tested the code that I posted.

As I state – with Yoast SEO installed your code only works for “Map View” (writing out “Map View” as browser window title) and not for “List View” or “Week View”

I tend to think that perhaps it would be more accurate to state that in the context of your installation and with the very same theme, plugins and an identical set of data and settings, it behaves in the manner you’ve detailed.

• Using the latest builds of our plugins currently available – plus WordPress SEO 1.5.2.6 by Joost de Valk and with the Twenty Thirteen theme activated – I find it behaves as I have already described, in the context of my own installation
• It might behave differently for you, depending on what you have activated and what settings are in place
• If it doesn’t meet your needs you’re going to have to research why it behaves the way it does (within the unique context of your own installation) and adapt it appropriately, we can’t step in and troubleshoot this for you

Lars: you want to use our plugins and WordPress SEO by Yoast, that’s great and there’s no reason not to – especially as you already are aware of some of the filters you can use and so you’re part of the way there. I’m afraid the rest is up to you.

Good luck!

[Author]

Posts