Minor issues in Version 3.8

[Oliver]

Hi!
I installed version 3.8! Looks really good! Great job!

Unfortunately I found some minor issues:

1. For reoccuring events the date isn’t display properly:
http://www.treffpunkt-jazz.de/event/solo-workshop-jazzgesang-und-gitarrenbegleitung/2014-10-02/
Beginn:
02. Oktober 00000010 17:00
Ende:
05. Oktober 00000010 13:00

2. In the backend some translations are missing, even the text was translated. I guess the wrong text domain was used (in the translation file the text domain “default” is used instead of “tribe-events-calendar”):
Screenshot:
https://www.dropbox.com/s/21gidnxy8f29ocb/Screenshot%202014-10-02%2014.44.04.png?dl=0

3. In the backend in the events listing the following text isn’t translated even the text was translated:
http://www.treffpunkt-jazz.de/wp-admin/edit.php?post_type=tribe_events
Screenshot:
https://www.dropbox.com/s/x9z5aw19hamwuuc/Screenshot%202014-10-02%2014.57.28.png?dl=0
– Filters & Columns
– Add a filter
– Add a colum
– Apply
– Clear
– Save

In addition there is an empty row the in dropdown selector. This empty row is the “comments” column.

Best regards,
Oliver

[Josh]

Hello Oliver,

Thanks for reaching out to us and bringing these things to our attention!

1. This is definitely a strange issue to be having. To start, what is your current setting for the “Date Time Separator” under the Display settings? (https://cloudup.com/c9fMYbgsyYM).

2 & 3. I’ll bring these issues to the attention of our translations person. Which language translation are you currently using?

Thanks!

[Oliver]

Hi Josh,

For 1: I’m using ” um ” (german for “at”). As a workaround I changed it ” @ “, which works. Really strange. Any idea how to solve this?

For 2+3: It’s the translation to german.

Best regards,
Oliver

[Leah]

Hiya Oliver,

I’m here to take a look at #2 and #3 that you mentioned 🙂

#2 – As far as I can see, the stuff in English are new strings that we just added in 3.8. Those will need to be translated with the latest .pot file. Since the release notes are always new for a version those will always be in English I’m afraid. Are you seeing other parts that are in the 3.7 .pot file but are not translated here? If you can be specific about those I can see able getting them fixed.

3. Thanks for bringing this up. Translating that part of the admin (it’s known as the APM) is difficult because parts of it load before the translations do. It also historically had a different text domain. It looks like there in once again an issue with the text domain here. I have ticketed this issue so we can look into it further. Thanks for bringing it to our attention!

Best,
Leah

[Josh]

Thanks for the input Leah!

Oliver,

I tried some testing on the separator value and wasn’t able to recreate. I’m curious if maybe resetting it to “@” possibly cleared out some possible extra characters that may have been stored. That being the case, I wonder if it would work if you changed it back to ” um ” now?

Thanks!

[Oliver]

I changed it back to ” um “, back it now shows again the wrong format:
http://www.treffpunkt-jazz.de/event/solo-workshop-jazzgesang-und-gitarrenbegleitung/2014-10-02/
Any new idea?

Best regards,
Oliver

[Oliver]

Hi Josh,
I guess I found the reason for the problem. Please have a look at the php date function:
http://php.net/manual/en/function.date.php.
It looks, that the separator text is interpreted by the date-function, too (what should not be the case as any text should allowed):
“u” (= microseconds) = 000000
“m” (=month) = 10

So we get the “00000010” in the details:
02. Oktober 00000010 17:00

Best regards,
Oliver

[Oliver]

For 2):
I understand, so the release notes can’t be translated. From my side this is not a real problem 😉

The text on the right hand side are in the file tribe-events-calendar-de.po, but as textdomain “default” is used (wrongly and should probably be changed):
“Every time your rate 5 stars …”
“We sent out discounts …”

Apart from these there are some more text that are using (wrongly) the textdomain “default”:
https://www.dropbox.com/s/i0yuulz31ep0fev/Screenshot%202014-10-04%2020.20.54.png?dl=0

You can easily check this with the WordPress Plugin “CodeStyling Localization” (I’m using it for all translation, because it’s supersimple, works always and shows pretty fast wrong textdomains 😉

Best regards,
Oliver

[Oliver]

Apart from that I found another string which isn’t translated, even it’s in the /tribe-events-calendar-pro-de_DE.po file:
http://www.treffpunkt-jazz.de/event/vincent-peirani-thrill-box-feat-michael-wollnymichel-benita/
The title “Other” for the user-defined fields isn’t translated.

I guess the problem is that the text domain is there two times:

Line 1086:
#: lib/SingleEventMeta.php:143
#: views/pro/modules/meta/additional-fields.php:15
#@ tribe-events-calendar-pro
#@ tribe-events-calendar
msgid “Other”
msgstr “Andere”

Best regards,
Oliver

[Oliver]

Just to let you know: I have solved the issues by changing the textdomain in all three files (SingleEventMeta.php, additional-fields.php, tribe-events-calendar-pro-de_DE.po) to “tribe-events-calendar-pro” (but I’m not sure about the overall impacts so better double check it before using this solution…)

[Josh]

Hello Oliver,

Thanks for following up and providing the useful information.

I checked the source for the output of the date time separator and saw that it is output along with tribe_get_start_date which does have the formatting set within the plugin options applied to it. However it is strange that it isn’t recreating for me locally. A couple of quick questions:

1. <span style=”line-height: 13px;”>Does the formatting persist if you switch to a default theme (TwentyTwelve) and disable other plugins?</span>
2. Could you send me a screenshot of all of the date format settings from the “Display” tab of the plugin settings? https://cloudup.com/cllWETwQRg3

Thanks!

[Leah]

Hi Oliver,

Thanks for the info on #2. I’ve ticketed those strings to be fixed in an upcoming update.

For that other string- I see what you mean about it having two text domains, which is weird. Can you show me where that string is on the site? I couldn’t find it in that link you sent me, although I do see it in the .php files.

Best,
Leah

[Oliver]

@Leah: thanks for ticketing #2.
For the string please click here
http://www.treffpunkt-jazz.de/event/vincent-peirani-thrill-box-feat-michael-wollnymichel-benita/
and look in the event details section for “Weitere Angaben” (Sorry, I changed the german translation – it was “Andere” before.

[Oliver]

@Josh: We are getting there!
I tried to reproduce the issue on my test website, but – surprise surprise – I can’t. On the test website everything works fine!
After thinking about it I guess that I manually changed the code as a workaround some months ago (because there was another issue with the translation), but can’t remember exactly where. Can you tell me which file is responsible for display that part? Would be a great help! 🙂

[Josh]

Hello Oliver,

Thanks for following up!

You can find the code for the tribe_events_event_schedule_details within the core plugin here.

Thanks!

[Author]

Posts