Calendar and HTML5Maker banners conflict?

[vancouverfamily]

Hi all,

I use the HTML5Maker site to generate ad banners on my site. For the past 2 days, the ads on the calendar pages aren’t showing. Instead, a large white block is. This is only happening on the calendar pages. I used the Developer Tools in FireFox to find out what the white object was. It is the ad container. This error, for instance, is showing on http://vancouverfamilymagazine.com/event/harry-potter-art-display/2015-08-01/

Is this a conflict with the calendar and my HTML5Maker banners? The banners use HTML5 and iframes.

[George]

Hey @vancouverfamily,

Sorry to hear about these issues! I checked out the link you provided and found the following JavaScript there, specifically:

TypeError: s5.substring is not a function

This is indeed coming from code related to the HTML5Maker banners, it’s coming from code you seem to have pasted into a text widget specifically.

Unfortunately, the only things I can think of that would cause banners to work on some pages, but not on ones generated by The Events Calendar, are theme-related things. That seems to be the case in fact – for example, in both locations the banner is wrapped in a div tag with the class “top-banner-advertisement”. However, on the markup for the banner on your site’s homepage, this div is wrapped in a section tag with the id “banner-top-block”, but this section is not found around that div on the Calendar pages…

That may seem like an irrelevant inconsistency, but I don’t know how HTML5Maker works and how it’s using the layout of your site.

So with all this being said, one thing you can try doing is going to Events > Settings > Display in your wp-admin, and trying all the different various options for the “Events Template” setting. Change it from what it is now, save the settings, and then drag a text widget with your code back in place in that banner area – then check out the front-end of the site and see if anything is improved.

If not, then unfortunately the next best step I can recommend is to contact support for HTML5Maker directly and inquire about this. The Events Calendar itself does not have any code that will prevent any of the core components for these banners from working: it won’t limit the functionality of widgets, iFrames, or HTML tags in any way. So there may be a problem with the HTML5Maker code itself, and/or with the handling of widgets or loading of JavaScript from your theme or something.

There’s a lot of information here but I hope it helps – let us know if that’s the case! And if you try out various options for the “Events Template” setting, let us know if any of the page templates work better than others.

Thanks!
George

[vancouverfamily]

Hi! Thanks for responding to my inquiry. I’ve managed to “contain” the white box on the page so it’s not running over my content, but the box itself is persisting. Here’s what I’ve tried:

1. All the different views with skeleton css to full-fledged Calendar css.

2. Modifying the code in my child tribe-events/default-template.php file to this:

<!-- Header Advertisement -->
<section id="banner-top-block" style="clear:both; display:block; width:100%;">
<div class="top-banner-advertisement">
<?php if ( ! dynamic_sidebar( 'Top Banner Advertisement' )) :  endif; ?>	
</div>		
</section>

Since you listed the JavaScript error, I’ll contact the HTML5Maker developers next to see if there’s an alternate code without that function. I’m betting you’re right: that it’s a calendar/theme/HTML5Maker conflict. I’ve seen this before with JavaScript version conflicts on pages… hope I can figure out just what’s going on though…

[George]

Hey @vancouverfamily, thanks for investigating these things. I’m curious – why did you make that dynamic_sidebar() code in your theme look like this:

<?php if ( ! dynamic_sidebar( 'Top Banner Advertisement' )) : endif; ?>

If you need that sidebar to be there, you’d need some code like this:


<?php

if ( dynamic_sidebar( 'Top Banner Advertisement' ) ) {
dynamic_sidebar( 'Top Banner Advertisement' );
}

?>


If you don’t want anything to be there, you should remove the PHP code altogether. Your current code basically says “If there is no dynamic sidebar for “Top Banner Advertisement”, then display nothing”.

That could be problematic here…just an idea!

Definitely contact your other plugin developer and see if progress can be made here. I should underscore the fact that we can’t support custom code or third-party plugins, however, so even if they give a lengthy response there may be little that we can help with, per se…

Apologies for the disclaimers 🙂 Just want to keep expectations reasonable and such, but please do keep us posted on this and let us know what you learn.

Cheers,
George

[vancouverfamily]

Hi there! That was the original code from the premium theme I’m using. I guess that Q would be better asked of the theme developers… ?

Your code is better — so you bet I snatched it to use! Thanks. =)

[George]

Hey @vancouverfamily,

I see this thread is marked “resolved” – did you happen to get things working here?

By and large, yes, the question you posed in your last reply and just about all other questions relating to the Banner advertisement itself would be best suited for your theme developer and/or the maker of that banner plugin directly.

— George

[Support Droid]

This topic has not been active for quite some time and will now be closed.

If you still need assistance please simply open a new topic (linking to this one if necessary)
and one of the team will be only too happy to help.

[Author]

Posts