- This topic has 13 replies, 4 voices, and was last updated 11 years, 10 months ago by
.
-
Posts
-
This began with my upgrade from 3.4=>3.5: I choose “View As List” without specifying a date. I correctly receive a list of near-future Events that haven’t yet happened. I then click the “Previous Events” link. I correctly receive a page of the most recent past events. However, from that point on, if I click “Previous Events” again, I get that same page of the most recent past events, rather than earlier Events. (If I do the same thing in 3.4, each click of “Previous Events” will correctly take me back to earlier and earlier past events.)
Right now I only have 3.5 installed on my local development site. If you need me to set up a test site you can access in order to demonstrate the problem, please let me know.
bobs,
Thanks for reaching out! If you could set up a test environment where I can see this issue occurring in a server environment, that would allow me to investigate further. Thanks! š-Casey-
Bob,
I’m definitely seeing this issue in your environment (even after deactivating all plugins and switching to the 2014 theme), but I’m unable to replicate this issue in my local environment. Can you try replicating this with a fresh install of WordPress and an empty database? I’m wondering if this has something to do with some errant data in your database.If the issue still persists, can you try testing locally or on a different server? That will help us to rule out your webhost’s server config also.
Give that a shot and let me know if the issue still persists. Thanks! š
-Casey-
Casey,
I have already tested on a local server (using MAMP)–that’s how I first discovered the problem.
As far as a fresh install of WordPress and an empty database goes, I’m not really clear what you’re asking. Are you suggesting I start from scratch and then create a bunch of bogus Events and see if the same thing happens? That would take a great deal of time, and even if it didn’t lead to the same results–which would imply there’s something in the data triggering the problem–I think that would still mean there’s a problem Modern Tribe needs to fix. I think a more fruitful step at this point would be for you or someone else at MT to do some diagnostics on the test setup I’ve given you and see what’s happening at the point the “Previous Events” link fails. If you want to move things to your own dev environment, you can use WP Migrate DB (already on the site) to obtain the database and the March 31 BackWPUp backup archive (also on the site) to obtain the files.
Thanks.
– Bob
Bob,
Can you try updating PRO to version 3.5.1 to see if that fixes your issue here? If not, let me know and I’ll continue to investigate. Thanks! š-Casey-
Bob,
What are your WP Memory limit settings set to? Since I’m not seeing these issues on my end, but we’re still seeing them in your environment with the default themes, I suspect that this is something related to your server configuration.Can you try increasing the memory limit in PHP/WordPress to see if that helps resolve the issue?
128M in my development environment. As I mentioned, the problem occurs both there and in the test environment I gave you access to. I highly doubt it’s memory-related.
When you say “Iām not seeing these issues on my end”, specifically what have you done that you’re referring to?
As I suggested previously, I believe you should be able to download files & database to your own environment, if necessary, and then trace the code execution at the point the error occurs. I think it’s very likely you’re going to find a program bug that was introduced in v 3.5.
Thanks.
I had this issue on my dev staging site as well, where in List View the first page of Past Events would show correctly, but clicking “Previous Events” would go no further. I was able to fix it after comparing the 3.5 template to the old 3.4 one, but I’m not entirely sure how what I changed would affect this issue.
In the template views/list/nav.php there is an li class of “tribe-events-nav-previous” on lines 21, 28 and 31, and an li class of “tribe-events-nav-next” on lines 40, 43 and 48. I changed the class on line 21 from ‘previous’ to ‘next’, and on both lines 40 and 43 from ‘next’ to ‘previous’, and got it to correctly go back and forth through the events.
Again, I really don’t know how the li classes affect the link navigation, and why only past events were broken and not upcoming events, but that’s the only change I made to get it working again. Does this help at all Bob?
Thanks Colby. Even though you weren’t sure why your fixed worked, I believe you DID find the bug. Between v3.4 and v3.5, in nav.php, if the listing is of past events, Modern Tribe changed the class assigned to the left navigation link from “tribe-events-nav-next” to “tribe-events-nav-previous”. It also changed the class assigned to the right navigation link from “tribe-events-nav-previous” to “tribe-events-nav-next”. The result of this change, in conjunction with the logic in tribe-events-ajax-list.js, is a bug.
I believe the code in tribe-events-ajax-list.js uses this class in forming a portion of the URL for the next page of events. As a result of the change to nav.php, this now leads to the following erroneous result: If the user clicks on the left navigation link (older events), the Ajax code should INCREMENT the “tribe_paged=#” portion of the URL, but instead it DECREMENTS it if greater than 1, or leaves it alone if it is 1. If the user clicks on the right navigation link (newer events), the Ajax code should DECREMENT the “tribe_paged=#”, but instead it INCREMENTS it.
The first screen of past events has a URL of …events/past/?action=tribe_list&tribe_paged=1. From that screen, the left navigation link should change the URL to …tribe_paged=2, but because of the bug, it leaves “paged” at 1. That’s why there’s no change in the events shown.
The right navigation link should result in …events/upcoming/?action=tribe_list&tribe_paged=1, but because of the bug it increments “paged”, resulting in an erroneous …upcoming/?action=tribe_list&tribe_paged=2.
Casey, while there may be some details we’ve missed, I believe we’ve now identified essence of the bug, and you should be able to pass it to Development to get it fixed.
Thanks.
Bob
Bob,
You are definitely right! I misunderstood the issue you were describing at first, but I’m now seeing the same behavior in my environment. I’ve ticketed this for our developers to review, and will let you know when I have more information for you.Stay tuned! Thanks! š
-Casey-
Hi there,
I just wanted to let you know that we have been working diligently on a fix for this issue. Our next release (3.6) will be available soon and should correct this problem. Please keep an eye on your Plugins and Updates pages for a version update. If you are still having problems after updating, please start a new thread with the details and we can assist you.
Best,
Leah
- The topic ‘3.5: View As List: "Previous Events" Link Fails’ is closed to new replies.