{"id":1407002,"date":"2017-12-16T03:47:25","date_gmt":"2017-12-16T11:47:25","guid":{"rendered":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/"},"modified":"2017-12-16T03:47:25","modified_gmt":"2017-12-16T11:47:25","slug":"filtering-shows-past-events","status":"closed","type":"topic","link":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/","title":{"rendered":"filtering shows past events"},"content":{"rendered":"

Hi,<\/p>\n

This is a continuation of this issue: https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-now-shows-past-events\/ For some reason your private responses aren’t shown to me, even though they’re in my thread and I’m logged in. Anyway, as you’ll see there:<\/p>\n

    \n
  1. The issue is that when filtering is applied, past events are shown.<\/li>\n
  2. I went through very extensive testing (plugin \/ theme conflicts, etc.).<\/li>\n
  3. In the end, because the Filter Bar update had completely broken our customisations, we decided on a radical approach of ditching all our customisations (which were extensive and working fine until your latest update – it was decided we were spending too much time managing clashes between updates and customisations, though, and the customisations are the only part of the process we have control over). We’ve added very minimal customisations back in.<\/li>\n<\/ol>\n

    We were hoping that the overhaul would lose the ‘past events’ issue, and it seemed that way in testing. But launching the new code, we’ve encountered the same problem again.<\/p>\n

    We’ve wasted a lot of time working with these problems with your plugin, so I’d appreciate prompt and thorough support here.<\/p>\n

    It may be necessary for a follow-up post so I can supply you with what you need to replicate our site and replicate the issue. However, here’s some of my debugging \/ notes:<\/p>\n

    Our custom theme has one function hooked to pre_get_posts, and the only thing it’s doing is this. We were assured that this would make sure past events are never shown, but obviously it’s not working:<\/p>\n

    if ( $query->get( 'tribe_is_past' ) ) {\n\t$query->set( 'post__in', array( 0 ) );\n}<\/code><\/pre>\n
    Getting into WP_Query, when I dump the request just before it’s run, using the posts_request hook, the SQL looks OK except – to my eye, and given the issue we’re looking at – that the meta_key for _EventEndDate is specified, but the meta key for _EventStartDate is NOT specified. Maybe your engineers could make something of that? If not let me know and we can progress with getting you replicating the issue to fix it.<\/p>\n
    SELECT SQL_CALC_FOUND_ROWS DISTINCT wp_posts.*,\n                                    MIN(wp_postmeta.meta_value) AS EventStartDate,\n                                    MIN(tribe_event_end_date.meta_value) AS EventEndDate\nFROM wp_posts\nINNER JOIN wp_postmeta ON (wp_posts.ID = wp_postmeta.post_id)\nLEFT JOIN wp_postmeta AS tribe_event_end_date ON (wp_posts.ID = tribe_event_end_date.post_id AND tribe_event_end_date.meta_key = '_EventEndDate')\nWHERE 1=1\n  AND ((wp_postmeta.meta_key = '_yh_venue_area'\n        AND wp_postmeta.meta_value = '38'))\n  AND wp_posts.post_type = 'tribe_events'\n  AND (wp_posts.post_status = 'publish'\n       OR wp_posts.post_status = 'tribe-ea-success'\n       OR wp_posts.post_status = 'tribe-ea-failed'\n       OR wp_posts.post_status = 'tribe-ea-schedule'\n       OR wp_posts.post_status = 'tribe-ea-pending'\n       OR wp_posts.post_status = 'tribe-ea-draft'\n       OR wp_posts.post_status = 'private')\n  AND (wp_postmeta.meta_value >= '2017-12-16 11:31:00'\n       OR (wp_postmeta.meta_value <= '2017-12-16 11:31:00'\n           AND tribe_event_end_date.meta_value >= '2017-12-16 11:31:00'))\nGROUP BY wp_posts.ID\nORDER BY EventStartDate ASC,\n         wp_posts.post_date ASC\nLIMIT 0, 10<\/code><\/pre>\n","protected":false},"template":"","class_list":["post-1407002","topic","type-topic","status-closed","hentry"],"yoast_head":"\nfiltering shows past events -<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"filtering shows past events -\" \/>\n<meta property=\"og:description\" content=\"Hi, This is a continuation of this issue: https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-now-shows-past-events\/ For some reason your private responses aren’t shown to me, even though they’re in my thread and I’m logged in. Anyway, as you’ll see there: The issue is that when filtering is applied, past events are shown. I went through very extensive testing (plugin \/ theme […]\" \/>\n<meta property=\"og:url\" content=\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data1\" content=\"3 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"WebPage\",\"@id\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/\",\"url\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/\",\"name\":\"filtering shows past events -\",\"isPartOf\":{\"@id\":\"https:\/\/theeventscalendar.com\/support\/#website\"},\"datePublished\":\"2017-12-16T11:47:25+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/theeventscalendar.com\/support\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"Topics\",\"item\":\"https:\/\/theeventscalendar.com\/support\/topics\/\"},{\"@type\":\"ListItem\",\"position\":3,\"name\":\"Calendar Products\",\"item\":\"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/\"},{\"@type\":\"ListItem\",\"position\":4,\"name\":\"Filter Bar\",\"item\":\"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/filter-bar\/\"},{\"@type\":\"ListItem\",\"position\":5,\"name\":\"filtering shows past events\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/theeventscalendar.com\/support\/#website\",\"url\":\"https:\/\/theeventscalendar.com\/support\/\",\"name\":\"\",\"description\":\"\",\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/theeventscalendar.com\/support\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"filtering shows past events -","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/","og_locale":"en_US","og_type":"article","og_title":"filtering shows past events -","og_description":"Hi, This is a continuation of this issue: https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-now-shows-past-events\/ For some reason your private responses aren’t shown to me, even though they’re in my thread and I’m logged in. Anyway, as you’ll see there: The issue is that when filtering is applied, past events are shown. I went through very extensive testing (plugin \/ theme […]","og_url":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/","twitter_card":"summary_large_image","twitter_misc":{"Est. reading time":"3 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"WebPage","@id":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/","url":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/","name":"filtering shows past events -","isPartOf":{"@id":"https:\/\/theeventscalendar.com\/support\/#website"},"datePublished":"2017-12-16T11:47:25+00:00","breadcrumb":{"@id":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/filtering-shows-past-events\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/theeventscalendar.com\/support\/"},{"@type":"ListItem","position":2,"name":"Topics","item":"https:\/\/theeventscalendar.com\/support\/topics\/"},{"@type":"ListItem","position":3,"name":"Calendar Products","item":"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/"},{"@type":"ListItem","position":4,"name":"Filter Bar","item":"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/filter-bar\/"},{"@type":"ListItem","position":5,"name":"filtering shows past events"}]},{"@type":"WebSite","@id":"https:\/\/theeventscalendar.com\/support\/#website","url":"https:\/\/theeventscalendar.com\/support\/","name":"","description":"","potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/theeventscalendar.com\/support\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"}]}},"_links":{"self":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic\/1407002","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic\/1407002\/revisions"}],"wp:attachment":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/media?parent=1407002"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}