Hi,<\/p>\n
I’ve been testing the new plugin versions on a local testing server and things seem to work OK once I replace template overrides with copies using the new version but I have been unable to make the French translation of the Event Tickets Plus plugin work. All strings always display in English.<\/p>\n
I use POEdit and tried updating the translations from the PO files, from source, creating new ones but nothing worked. I always only see the English strings.<\/p>\n
Then I started poking in the plugin files to make sure the text domain was correct and nothing else was weird and I found why it didn’t work.<\/p>\n
If you look at the event-tickets-plus.php file at the root of the plugin folder, the only call to load_plugin_textdomain in the entire plugin is on line 43 and that is inside the following conditional: if ( event_tickets_plus_is_incompatible_tickets_core_installed() ) { …textdomain code }<\/p>\n
That event_tickets_plus_is_incompatible_tickets_core_installed() function is defined further down in the same file at line 70. Since I AM using a compatible version, that function always returns “false” so the translations are never actually loaded. I removed the above conditional on line 41 (closing at line 47) and the French translation worked right away.<\/p>\n
So something is broken with that logic as it seems to be loading the new plugin’s translation files only if one is running an incompatible version and no other action is taked if the function returns false. In that case, no translations are loaded at all which makes no sense to me.<\/p>\n
What’s up with that? In any case, I’ll definitely wait before upgrading on the live site until this is resolved.<\/p>\n
Thanks!<\/p>\n","protected":false},"template":"","class_list":["post-1036451","topic","type-topic","status-closed","hentry"],"yoast_head":"\n