{"id":1025545,"date":"2015-11-13T18:22:57","date_gmt":"2015-11-14T02:22:57","guid":{"rendered":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/"},"modified":"2015-11-16T07:24:23","modified_gmt":"2015-11-16T15:24:23","slug":"issues-with-german-translations-in-filter-bar-3-12-1","status":"closed","type":"topic","link":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/","title":{"rendered":"Issues with German translations in Filter Bar 3.12.1"},"content":{"rendered":"<p>Hi,<\/p>\n<p>in version 3.12.1 of the Filter Bar plugin I discovered some potential issues which I want to highlight here:<\/p>\n<p><strong>Textdomains<\/strong><br \/>\nThere are three textdomains used in tribe-events-filter-view-de_DE.po:<br \/>\nhttps:\/\/www.dropbox.com\/s\/xskup7y955ow16c\/Screenshot%202015-11-14%2003.16.46.png?dl=0<\/p>\n<p>a) Is the \u201cdefault\u201d-textdomain really needed? See line 294-298:<\/p>\n<pre><code>\n#: src\/views\/filter-bar\/filter-view-horizontal.php:30\n#: src\/views\/filter-bar\/filter-view-vertical.php:30\n#@ default\nmsgid &quot;Submit&quot;\nmsgstr &quot;Abschicken&quot;\n<\/code><\/pre>\n<p>b) Is the \u201ctribe-events-eventful-importer\u201d-textdomain really needed? It&#8217;s only used one time! See line 305-309:<\/p>\n<pre><code>\n#: the-events-calendar-filter-view.php:68\n#, php-format\n#@ tribe-events-eventful-importer\n<\/code><\/pre>\n<p>Putting HTML-elements inside an translation is not a best practice. Maybe this can be done more elegantly:<\/p>\n<pre><code>\nmsgid &quot;To begin using The Events Calendar: Filter Bar, please install the latest version of &lt;a href=&quot;%s&quot; title=&quot;%s&quot;&gt;The Events Calendar&lt;\/a&gt;.&quot;\nmsgstr &quot;&quot;\n<\/code><\/pre>\n<p>Best regards,<br \/>\nOliver<\/p>\n","protected":false},"template":"","class_list":["post-1025545","topic","type-topic","status-closed","hentry"],"yoast_head":"<!-- This site is optimized with the Yoast SEO plugin v25.2 - https:\/\/yoast.com\/wordpress\/plugins\/seo\/ -->\n<title>Issues with German translations in Filter Bar 3.12.1 -<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"Issues with German translations in Filter Bar 3.12.1 -\" \/>\n<meta property=\"og:description\" content=\"Hi, in version 3.12.1 of the Filter Bar plugin I discovered some potential issues which I want to highlight here: Textdomains There are three textdomains used in tribe-events-filter-view-de_DE.po: https:\/\/www.dropbox.com\/s\/xskup7y955ow16c\/Screenshot%202015-11-14%2003.16.46.png?dl=0 a) Is the \u201cdefault\u201d-textdomain really needed? See line 294-298: #: src\/views\/filter-bar\/filter-view-horizontal.php:30 #: src\/views\/filter-bar\/filter-view-vertical.php:30 #@ default msgid &quot;Submit&quot; msgstr &quot;Abschicken&quot; b) Is the \u201ctribe-events-eventful-importer\u201d-textdomain really needed? It&#8217;s [&hellip;]\" \/>\n<meta property=\"og:url\" content=\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/\" \/>\n<meta property=\"article:modified_time\" content=\"2015-11-16T15:24:23+00:00\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data1\" content=\"1 minute\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"WebPage\",\"@id\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/\",\"url\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/\",\"name\":\"Issues with German translations in Filter Bar 3.12.1 -\",\"isPartOf\":{\"@id\":\"https:\/\/theeventscalendar.com\/support\/#website\"},\"datePublished\":\"2015-11-14T02:22:57+00:00\",\"dateModified\":\"2015-11-16T15:24:23+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/theeventscalendar.com\/support\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"Topics\",\"item\":\"https:\/\/theeventscalendar.com\/support\/topics\/\"},{\"@type\":\"ListItem\",\"position\":3,\"name\":\"Calendar Products\",\"item\":\"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/\"},{\"@type\":\"ListItem\",\"position\":4,\"name\":\"Community Events\",\"item\":\"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/community-events\/\"},{\"@type\":\"ListItem\",\"position\":5,\"name\":\"Issues with German translations in Filter Bar 3.12.1\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/theeventscalendar.com\/support\/#website\",\"url\":\"https:\/\/theeventscalendar.com\/support\/\",\"name\":\"\",\"description\":\"\",\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/theeventscalendar.com\/support\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"Issues with German translations in Filter Bar 3.12.1 -","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/","og_locale":"en_US","og_type":"article","og_title":"Issues with German translations in Filter Bar 3.12.1 -","og_description":"Hi, in version 3.12.1 of the Filter Bar plugin I discovered some potential issues which I want to highlight here: Textdomains There are three textdomains used in tribe-events-filter-view-de_DE.po: https:\/\/www.dropbox.com\/s\/xskup7y955ow16c\/Screenshot%202015-11-14%2003.16.46.png?dl=0 a) Is the \u201cdefault\u201d-textdomain really needed? See line 294-298: #: src\/views\/filter-bar\/filter-view-horizontal.php:30 #: src\/views\/filter-bar\/filter-view-vertical.php:30 #@ default msgid &quot;Submit&quot; msgstr &quot;Abschicken&quot; b) Is the \u201ctribe-events-eventful-importer\u201d-textdomain really needed? It&#8217;s [&hellip;]","og_url":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/","article_modified_time":"2015-11-16T15:24:23+00:00","twitter_card":"summary_large_image","twitter_misc":{"Est. reading time":"1 minute"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"WebPage","@id":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/","url":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/","name":"Issues with German translations in Filter Bar 3.12.1 -","isPartOf":{"@id":"https:\/\/theeventscalendar.com\/support\/#website"},"datePublished":"2015-11-14T02:22:57+00:00","dateModified":"2015-11-16T15:24:23+00:00","breadcrumb":{"@id":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/theeventscalendar.com\/support\/forums\/topic\/issues-with-german-translations-in-filter-bar-3-12-1\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/theeventscalendar.com\/support\/"},{"@type":"ListItem","position":2,"name":"Topics","item":"https:\/\/theeventscalendar.com\/support\/topics\/"},{"@type":"ListItem","position":3,"name":"Calendar Products","item":"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/"},{"@type":"ListItem","position":4,"name":"Community Events","item":"https:\/\/theeventscalendar.com\/support\/forums\/forum\/events\/community-events\/"},{"@type":"ListItem","position":5,"name":"Issues with German translations in Filter Bar 3.12.1"}]},{"@type":"WebSite","@id":"https:\/\/theeventscalendar.com\/support\/#website","url":"https:\/\/theeventscalendar.com\/support\/","name":"","description":"","potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/theeventscalendar.com\/support\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"}]}},"_links":{"self":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic\/1025545","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":1,"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic\/1025545\/revisions"}],"predecessor-version":[{"id":1026351,"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/topic\/1025545\/revisions\/1026351"}],"wp:attachment":[{"href":"https:\/\/theeventscalendar.com\/support\/wp-json\/wp\/v2\/media?parent=1025545"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}